1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Altering Item - not working?

Discussion in 'Archived Bug Reports' started by WarFace, Nov 30, 2013.

  1. WarFace
    Offline

    WarFace Member

    Joined:
    Nov 25, 2013
    Messages:
    27
    Likes Received:
    5
    Does anyone know why altering item does not work?I use a kit or barbed kit and try to press alter item and it does nothing but go back into cursor form
    --- Double Post Merged, Nov 30, 2013, Original Post Date: Nov 30, 2013 ---
    aint i missing a bit of god here to link it with AlterItem.cs?

    This code is located in the craftgump.cs

    Code (C#):
    1. #region SA
    2.                             case 9: // Alter Item (Gargoyle)
    3.                                 {
    4.                                     break;
    5.                                 }
    6.                             case 10: // Quest Item/Non Quest Item toggle
     
  2. WarFace
    Offline

    WarFace Member

    Joined:
    Nov 25, 2013
    Messages:
    27
    Likes Received:
    5
    So i guess no one has came down with anything that would get this working, i ran into some things

    So i opened CraftGump.cs

    took this

    Code (C#):
    1. #region SA
    2.                             case 9: // Alter Item (Gargoyle)
    3.                                 {
    4.                                     break;
    5.                                 }
    and added code in there, now its this

    Code (C#):
    1. #region SA
    2.                             case 9: // Alter Item (Gargoyle)
    3.                                 {
    4.                                     if (system.AlterItem)
    5.                                         AlterItem.BeginTarget(this.m_From, system, this.m_Tool);
    6.  
    7.  
    8.  
    9.  
    10.                                     break;
    11.                                 }
    So i was erroring out for a bit had to go into CraftSystem.cs and added this code right above QuestOption on line 207

    Code (C#):
    1. #region SA
    2. public bool AlterItem
    3.         {
    4.             get
    5.             {
    6.                 return this.m_AlterItem;
    7.             }
    8.             set
    9.             {
    10.                 this.m_AlterItem = value;
    11.             }
    12.         }
    13.  
    Also had to add Private bool m_AlterItem to this bit of code at the top of craftsystem.cs

    Code (C#):
    1. public abstract class CraftSystem
    2.     {
    3.         private readonly int m_MinCraftEffect;
    4.         private readonly int m_MaxCraftEffect;
    5.         private readonly double m_Delay;
    6.         private bool m_Resmelt;
    7.         private bool m_Repair;
    8.         private bool m_MarkOption;
    9.         private bool m_CanEnhance;
    10.         #region SA
    11. private bool m_AlterItem;
    12.         private bool m_QuestOption;
    13.         #endregion
    Its now running without errors but still when i press alter item in any of the runic tool gumps ingame, it does nothing. Am i missing somthing, could it be the AlterItem.cs script its self?
     
  3. WarFace
    Offline

    WarFace Member

    Joined:
    Nov 25, 2013
    Messages:
    27
    Likes Received:
    5
    When you open a runic tool gump, Hammer, sewing kit. It does nothing when you press Alter Item, i did do some coding to see if i could get it to work, implemented code successfully but still does nothing. Any help with this bug would be awesome guys.

    Heres the link to the post

    Alter Item Not Working LINK
     
  4. WarFace
    Offline

    WarFace Member

    Joined:
    Nov 25, 2013
    Messages:
    27
    Likes Received:
    5
    Still looking for help :(
     
  5. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    Only one edit needed to fix this.

    In Craftgump.cs:

    Code (C#):
    1. case 9: // Alter Item (Gargoyle)
    2.                                 {
    3.                                  AlterItem.BeginTarget(this.m_From, system, this.m_Tool);
    4.                                  break;
    5.                                 }
    The other edits you made are not needed unless you are wanting to make a bool to turn off the ability to alter items. Your code wasn't working because the bool you created was not set to true and therefore the if statement was failing. If you want to keep the bool so that you can disable the system, then you will need to set it true somewhere.
     
    #5 Ravenwolfe, Dec 2, 2013
    Last edited: Dec 2, 2013
    • Agree Agree x 1
  6. WarFace
    Offline

    WarFace Member

    Joined:
    Nov 25, 2013
    Messages:
    27
    Likes Received:
    5
    I now see what i did there haha, i feel stupid. Come back to UO a little rusty after 3 years. Sorry about that. Now as far as imbuing goes is that not working with servuo or do you have to turn it on?


    BTW Thank you very much Raven!
     
  7. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    Hey, I get rusty after 3 days!!

    Imbuing is not working by default in ServUO yet, there is a package on RunUO that can be adapted to work with ServUO that is fairly decent. Mine is heavily edited but I know someone posted one before and will probably post it again once the Archive is fixed. You also have to adjust the drops, which I am still working on at this point.
    --- Double Post Merged, Dec 3, 2013, Original Post Date: Dec 3, 2013 ---
    Ok, I think I found the one before my edits..
     

    Attached Files:

    • Agree Agree x 1
  8. WarFace
    Offline

    WarFace Member

    Joined:
    Nov 25, 2013
    Messages:
    27
    Likes Received:
    5
  9. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    Did you use the one from RunUO or that one I posted? The one from RunUO will have errors but I thought the one I posted worked...
     
  10. Taelis
    Offline

    Taelis New Member

    Joined:
    Nov 23, 2013
    Messages:
    8
    Likes Received:
    2
    I made a post under script support that has the imbuing system fully integrated with publish 54. I also posted my shards custom drop table if you wanted that.
     
  11. RedBeard
    Offline

    RedBeard Active Member

    Joined:
    May 19, 2013
    Messages:
    365
    Likes Received:
    72
    Alter Item doesn't work properly. It will create the appropriate Item, however it will not carry or transpose the attributes or the name, whether it be a name of an artifact or an engraving. Also it is missing clothing, shoes, cloaks and quivers which will be tricky to add since cloaks and quivers turn into wing armor, so converting baseclothing to basearmor. As for Baseclothing and baseshoes (abstract class of baseclothing) I had trouble adding them. Another issue is it doesn't recognize tinker tools or carpentry tools. If it is a weapon you must use Blacksmith menu reguardless of what skill crafted it. The AlterItem.cs itself isn't OSI accurate, I have a more accurate copy if anyone wants to tinker with it [no pun intended].

    Edit*** Cloak and quivers to Baseclothing not Basearmor my mistake is gargish cloth wing armor
     
    #11 RedBeard, Dec 12, 2013
    Last edited: Dec 14, 2013
  12. m309
    Offline

    Admin Moderator ServUO Developer

    Joined:
    Mar 3, 2013
    Messages:
    1,243
    Likes Received:
    130
    @RedBeard that'd be great if you could share it
     
  13. RedBeard
    Offline

    RedBeard Active Member

    Joined:
    May 19, 2013
    Messages:
    365
    Likes Received:
    72
    Here is my AlterItem.cs based off Stratics
     

    Attached Files:

    • Agree Agree x 1
  14. WarFace
    Offline

    WarFace Member

    Joined:
    Nov 25, 2013
    Messages:
    27
    Likes Received:
    5
    Sorry should have said that this is now working :p
     
  15. cmileto
    Offline

    cmileto Member

    Joined:
    Nov 18, 2013
    Messages:
    174
    Likes Received:
    8
    i just changed over to this one and while I have done minimal testing I am getting no issues...
     
  16. arphile
    Offline

    arphile Active Member

    Joined:
    Apr 24, 2014
    Messages:
    159
    Likes Received:
    29
    does anyone know about altering cannot copy properties?
    I use this script, and altering Human/Elf weapons with attributes like spellchaining, but altered item doesn't have this property.
    all of the propertys and all type of items same.. altered items doesn't have any properties..
     
  17. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    Fixed and updated in main repo.
     
    • Two Thumbs Up Two Thumbs Up x 1
  18. Horian
    Offline

    Horian Member

    Joined:
    Aug 8, 2013
    Messages:
    121
    Likes Received:
    23
    Sorry to to dig that out again, I'm unfortunately not able yet to understand code, just working with things like [help dumps etc. There is an ingame command [alteritem which seems not to work - or I have no idea how to use it. Is this related and can someone with the ability to code maybe tell me how to use it or if it is broken?
     
Similar Threads: Altering Item
Forum Title Date
Archived Bug Reports Wearing, altering items for Gargoyle Feb 26, 2016
Archived Bug Reports Targeted_Item Crash Yesterday at 3:10 PM
Archived Bug Reports Luck came as a default prop with Hearthwood items, it shouldn't Tuesday at 7:20 AM
3rd Party Support Viewing Items Using UO Fiddler Monday at 3:07 PM
Archived Bug Reports Corrupted Crystal Portal uses wrong ItemID Monday at 8:38 AM
Script Support How to make a item execute a method that is made for a mobile? Oct 15, 2017
Bug Reports Faction Vendor Items VvV only Oct 15, 2017