1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Containers

Discussion in 'Archived Bug Reports' started by mordredrs, Aug 28, 2013.

  1. mordredrs
    Offline

    mordredrs Member

    Joined:
    Jul 28, 2013
    Messages:
    62
    Likes Received:
    4
    Ok. I promisse i'll stop after this one is fixed ;)
    I've a problem in any container (crafted or not): usually, containers [props have 05 pages. On my servuo i have only 04 (the 2nd one is missing).
    The second page of [props is the one with crafter and material names...
    Any insight? Milva has posted a gump, but i wasn't able to merge and make it work. Is anyone else having this problem?
    Thanks in advance for any help!
     
  2. tass23
    Offline

    Moderator

    Joined:
    Aug 28, 2013
    Messages:
    1,014
    Likes Received:
    131
    Mord, post your Container.cs for me please.
     
  3. Vorspire
    Offline

    Vorspire Vita-Nex: Core
    Admin ServUO Developer

    Joined:
    Jul 29, 2013
    Messages:
    920
    Likes Received:
    164
    Is this still an issue?
     
  4. Ziru
    Offline

    Ziru New Member

    Joined:
    Oct 26, 2013
    Messages:
    17
    Likes Received:
    1
    Yes. this still an issue.
     
  5. Vorspire
    Offline

    Vorspire Vita-Nex: Core
    Admin ServUO Developer

    Joined:
    Jul 29, 2013
    Messages:
    920
    Likes Received:
    164
    Think you can describe the issue in more detail?

    It might just be an AccessLevel thing, a lot of core properties require Decorator access as a minimum before they will be displayed - a missing page in the props would be the result of a few properties being trimmed out due to having a lower access level than their required read level.
     
  6. Milva
    Offline

    Admin Moderator

    Joined:
    Mar 3, 2013
    Messages:
    3,634
    Likes Received:
    397
    I just tested this with owner on Servuo and Runuo and there is a page missing, pretty sure that with Orb 3.0 it was normal/ ok, but I don't have Orb 3.0 any more :)
     
  7. Vorspire
    Offline

    Vorspire Vita-Nex: Core
    Admin ServUO Developer

    Joined:
    Jul 29, 2013
    Messages:
    920
    Likes Received:
    164
    Looks like a bunch of [CommandProperty] attributes may be missing.

    Any idea which specific properties are missing from the [Props menu?

    It's technically not missing a page as such, it's generated on the fly by getting a list of all properties on an object that have an attached [CommandProperty] attribute, so if they don't have that attribute, they won't be included in the list and would therefore mean less pages on the gump.
     
  8. Milva
    Offline

    Admin Moderator

    Joined:
    Mar 3, 2013
    Messages:
    3,634
    Likes Received:
    397
    I do know that page contains who crafted the container- not sure if it would help but I had posted the props gump script on craftuo from Orb if it would be needed that one did show the correct missing page. Oh wait I believe I had posted a SS of the missing page let me go grab it :)
    --- Double Post Merged, Oct 31, 2013, Original Post Date: Oct 31, 2013 ---
    SS of missing page 2ndpage.JPG
     
  9. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,155
    Likes Received:
    125
    Ah, it looks like its because basecontainer.cs does not exist in ServUO.
     
  10. Vorspire
    Offline

    Vorspire Vita-Nex: Core
    Admin ServUO Developer

    Joined:
    Jul 29, 2013
    Messages:
    920
    Likes Received:
    164
    You're almost right, BaseContainer exists, but it was implemented in such a way that the ML mods were left out and the serialize/deserialize can't be edited.

    None of the properties you'd expect for ML containers have been added to ServUO's BaseContainer, I'll probably have to find a way to work-around it, if we started adding to the serialize/deserialize now, the next reboot of your shard would want to wipe all saves.

    Thanks for the report - I'll try my best to get the missing ML content installed without destroying all containers :p
     
  11. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,155
    Likes Received:
    125
    Cool, thank you! I couldn't find a BaseContainer.cs, so I figured it wasn't there. I'm guessing its under another script?
     
  12. Vorspire
    Offline

    Vorspire Vita-Nex: Core
    Admin ServUO Developer

    Joined:
    Jul 29, 2013
    Messages:
    920
    Likes Received:
    164
    It's Scripts/Items/Containers/Container.cs

    BaseContainer is in there.
     
  13. Toriad
    Offline

    Toriad Shard Owner

    Joined:
    Mar 4, 2013
    Messages:
    86
    Likes Received:
    35
    I've got a fix in mind for this, however it will require some effort on the part of server owners. I will convert this into a milestone task for Publish 55.

    EDIT: Converted to Milestone Issue (Link)
     
  14. mordredrs
    Offline

    mordredrs Member

    Joined:
    Jul 28, 2013
    Messages:
    62
    Likes Received:
    4
    Thanks guys!
    When i'm not lurking in adm mode, i like to play with my crafter and lumberjacker ;)
     
Similar Threads: Containers
Forum Title Date
Archived Bug Reports Item containers position EC Oct 6, 2017
Archived Bug Reports Bypass Item Limit on Containers Aug 1, 2017
Archived Bug Reports Gold in Locked/Trapped Containers Mar 7, 2017
Script Support 2-7-17 update on containers issue - Squire Feb 7, 2017
Script Support Stop containers in backpack from closing when Recalling Jan 17, 2017
Script Support Utilizing mobiles as "animation containers" Jan 16, 2017
Script Support Help with containers Dec 31, 2016