1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Not A Bug Crashing every hour

Discussion in 'Archived Bug Reports' started by rhasce, Jul 13, 2018.

  1. rhasce
    Offline

    rhasce Member

    Joined:
    Jan 10, 2017
    Messages:
    168
    Likes Received:
    5
    Hi all I hope you are all well,

    So my server started to crash every hour today, Im running latest servuo repo commit, anyone else getting this?

    System.NullReferenceException: Object reference not set to an instance of an object.
    at Server.Mobiles.LoyaltyTimer.OnTick() in c:\Users\Administrator\Documents\GitHub\UOHQOSI\Scripts\Mobiles\Normal\BaseCreature.cs:line 8230
    at Server.Timer.Slice() in c:\Users\Administrator\Documents\GitHub\UOHQOSI\Server\Timer.cs:line 409
    at Server.Core.Main(String[] args) in c:\Users\Administrator\Documents\GitHub\UOHQOSI\Server\Main.cs:line 663
     

    Attached Files:

  2. Tasanar
    Online

    Moderator

    Joined:
    Oct 16, 2014
    Messages:
    4,042
    Likes Received:
    89
    Are you sure you have the latest ServUO? I feel like this was an issue in the past but it got fixed.

    Do you have any edits to BaseCreature?

    In the mean time I am going to move this over to Bug Reports. If it is due to custom code though I will move it back to Script Support.
     
  3. rhasce
    Offline

    rhasce Member

    Joined:
    Jan 10, 2017
    Messages:
    168
    Likes Received:
    5
    Let me compare, yes I been merging with latest and Im up to latest but let me compare.
     
  4. Tasanar
    Online

    Moderator

    Joined:
    Oct 16, 2014
    Messages:
    4,042
    Likes Received:
    89
    Code (C#):
    1.  
    2.             foreach (BaseCreature c in toRelease.Where(c => c != null))
    3.             {
    4.                 if (c.IsDeadBondedPet)
    5.                 {
    6.                     c.Delete();
    7.                     continue;
    8.                 }
    9.  
    10.                 c.Say(1043255, c.Name); // ~1_NAME~ appears to have decided that is better off without a master!
    11.                 c.Loyalty = BaseCreature.MaxLoyalty; // Wonderfully Happy
    12.                 c.IsBonded = false;
    13.                 c.BondingBegin = DateTime.MinValue;
    14.                 c.OwnerAbandonTime = DateTime.MinValue;
    15.                 c.ControlTarget = null;
    16.                 //c.ControlOrder = OrderType.Release;
    17.                 c.AIObject.DoOrderRelease();
    18.                 // this will prevent no release of creatures left alone with AI disabled (and consequent bug of Followers)
    19.                 c.DropBackpack();
    20.                 c.RemoveOnSave = true;
    21.             }
    Code (C#):
    1. c.AIObject.DoOrderRelease();
    is the error line number in his BaseCreature.

    Dexter I compared his code to Repo and it looks up to date. I remember I had issues with this but it has not appeared again. I wonder what is causing it?
     
  5. rhasce
    Offline

    rhasce Member

    Joined:
    Jan 10, 2017
    Messages:
    168
    Likes Received:
    5
    ok you beat me to it, I was installing winmerge hehe
     
  6. Dexter_Lexia
    Offline

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    3,388
    Likes Received:
    138
    Not sure how that is happening.
     
  7. rhasce
    Offline

    rhasce Member

    Joined:
    Jan 10, 2017
    Messages:
    168
    Likes Received:
    5
    Also I reduced the Bonding Abandoned delay by mistake so I guess some pets are trying to abandon on the hour, then the thing crashes, I think this is why it is been trigger on my server as some pets may have been tamed during the time that was set wrongly.

    Im talking about this:

    public virtual TimeSpan BondingAbandonDelay { get { return TimeSpan.FromDays(50.0)

    line 401 on Base creature I set to 1 by mistake :( oops
     
  8. Tasanar
    Online

    Moderator

    Joined:
    Oct 16, 2014
    Messages:
    4,042
    Likes Received:
    89
    Well it still should not crash there, when they release.
     
  9. Dexter_Lexia
    Offline

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    3,388
    Likes Received:
    138
    No reason the pet ai should be null, unless its from a custom pet/creature.
     
  10. rhasce
    Offline

    rhasce Member

    Joined:
    Jan 10, 2017
    Messages:
    168
    Likes Received:
    5
    I have this one added whill this one cause a crash?
     

    Attached Files:

  11. Dexter_Lexia
    Offline

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    3,388
    Likes Received:
    138
    doesn't look like it would.
     
  12. Tasanar
    Online

    Moderator

    Joined:
    Oct 16, 2014
    Messages:
    4,042
    Likes Received:
    89
    Yeah looks fine. Same thing happened to me a while back and I do not have any custom pets.
     
  13. rhasce
    Offline

    rhasce Member

    Joined:
    Jan 10, 2017
    Messages:
    168
    Likes Received:
    5
    should I revert the commented section?
    --- Double Post Merged, Jul 13, 2018 ---
    So for now I'm saving every 10 minutes :) so when it crashes they only lose 10 mins
     
  14. rhcrafa
    Offline

    rhcrafa New Member

    Joined:
    Jul 14, 2018
    Messages:
    2
    Likes Received:
    0
    It is me the creator of this post, I cant get on my other account as I logged using twitter and now that function is broken, this is a false alarm looks like the mannequins which is a custom thing was crashing server, I deleted them and no more crashes.
     
    #14 rhcrafa, Jul 14, 2018
    Last edited: Jul 14, 2018
Similar Threads: Crashing every
Forum Title Date
Archived Bug Reports Crashing every few minutes. Treasuremap SVN. Jun 7, 2018
Windows Support Server Crashing Jun 6, 2018
ServUO Discussion Players crashing when trying to trade Jun 2, 2018
Script Support Custom Ore Crashing Server May 18, 2018
General Discussion server crashing, being a pain in my **vjofufgvjlhv** Nov 10, 2017
Archived Bug Reports Player crashing when entering same area Sep 10, 2017
Archived Bug Reports Arisen Controller - non stop crashing my shard Aug 15, 2017