Fixed Gender NPC Bug

Found a boo-boo in the fix... Line 44
public override bool CanTeach { get { return false; } }
Needs to be true or else the vendors cant teach the players anything.

 

Another boo-boo... line 51
public virtual bool IsActiveBuyer { get { return false; } } // response to vendor SELL
Should be
public virtual bool IsActiveBuyer { get { return IsActiveVendor; } } // response to vendor SELL

 

Whoever made it might have wanted a player-based economy. 'Thus disabling the option to sell (not sure why buy would be enabled though - or why training would be disabled)..

 

What I did was use the stock file but move this line:

Utility.AssignRandomFacialHair(this, hairHue); <--- can be found directly underneath this line: Utility.AssignRandomHair(this, hairHue);



down maybe 5 or 6 lines to where vendor sex had already been decided. My basevendor is way to intertwined with other custom scripts to swap it out. Mine now looks like so:

Code (C#):

1.  
2. Utility.AssignRandomHair(this, hairHue);
3. // line moved to correct female facial hair
4. if (Female)
5. {
6. switch (Utility.Random(6))
7. {
8. case 0:
9. AddItem(new ShortPants(GetRandomHue()));
10. break;
11. case 1:
12. case 2:
13. AddItem(new Kilt(GetRandomHue()));
14. break;
15. case 3:
16. case 4:
17. case 5:
18. AddItem(new Skirt(GetRandomHue()));
19. break;
20. }
21. }
22. else
23. {
24. switch (Utility.Random(2))
25. {
26. case 0:
27. AddItem(new LongPants(GetRandomHue()));
28. Utility.AssignRandomFacialHair(this, hairHue);
29. break;
30. case 1:
31. AddItem(new ShortPants(GetRandomHue()));
32. Utility.AssignRandomFacialHair(this, hairHue);
33. break;
34. }
35. }

a quick respawn of my vendors and its right as rain.

 

I don't want to appear rude, but I just downloaded what says it is the latest ZIP file of ServUO in order to test it and the first thing I noted was that many of the female vendors were bearded, and some of the male vendors had female hair/clothes. I search for this and I find this thread dated November 2013 and it is now September 2014. I also had two main.cs crashes which I also find in another thread with some fix suggestions. Why has the ZIP file not been updated with these changes? If I use git to download instead will I get all of these old fixes which are not in the ZIP file? Again, I really don't wish to offend anyone, especially as a software developer myself, but as someone arriving to look at this software and test it, it is instantly rather off-putting to find it doesn't work right! Can we get the ZIP file updated with all the latest debugged scripts?

 

Hi Milva and Ravenwolfe,

Thank you both for your explanations. I was trying my best not to appear ungrateful for your hard work which you provide for FREE

I am, perhaps, just a little confused with this SVN/Git type thing (of which I am a total newbie) because I thought the whole point of it was that these changes and bug-fixes automatically became available to everyone without having to make the code patches manually yourself. I guess I wasn't understanding why I wasn't getting them and I'm still not, really!

I am very well aware of the pressures of real life. Got quite a few myself, so you have my sympathy!

I have been setting up a UO server which has been an interesting learning process, but rather than using the system I have started with, I wanted to go for your system, ServUO, which has an active team actually working on it <grin> so I will just be patient and wait until you have something I can start building from.

Kind regards