1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed -luck items can trick Fame Based Point systems.

Discussion in 'Archived Bug Reports' started by hanghost, Feb 23, 2018.

  1. hanghost
    Offline

    hanghost New Member

    Joined:
    Jan 13, 2017
    Messages:
    28
    Likes Received:
    0
    Hello everyone

    This line of code can be found in a few places throughout the repository when it comes to storing fame based points:

    pm.VASTotalMonsterFame += (int)(bc.Fame * (1 + Math.Sqrt(pm.RealLuck) / 100))/10;

    Assuming that someone puts on a -luck item (can be found using the new RunicGenerator or just by browsing the Mysterious Wisp wares). The above starts giving -thousands of millions of points and makes the system trick into dropping the item by eventually overflowing i guess.

    Regards,
    Andrei.
     
  2. Tasanar
    Offline

    Moderator ServUO Developer

    Joined:
    Oct 16, 2014
    Messages:
    4,446
    Likes Received:
    96
    I can confirm this bug.

    confirmed.png

    So first I made a test character with a -100 luck item. I could not get it to bug out. However with -1000 luck it DID bug out.

    Since you can get a whole suit of items with -100 luck there needs to be something added where if luck < 0 luck = 0.
     
  3. hanghost
    Offline

    hanghost New Member

    Joined:
    Jan 13, 2017
    Messages:
    28
    Likes Received:
    0
    After checking the latest repository code, you might need more than -250 luck (so 3 items) depending on your settings due to how RealLuck is calculated but only if you are in Felucca.
     
Similar Threads: -luck items
Forum Title Date
Script Support Levelable item deed on exceptional items. Feb 26, 2019
Script Support Locking down items Feb 23, 2019
Script Support Adding line to check if items are locked down into basehouse Feb 19, 2019
Script Support Linking Items Dec 16, 2018
Script Support XML levelable items dont gain EXP. Dec 2, 2018
Script Support 1 item doesnt block 2 stacked items blocks player Nov 30, 2018
Archived Bug Reports Faction Leaders Not High Enough Rank to Equip Faction Items Nov 5, 2018