Master Branch Protection

So everybody in this list has enough time and experience to review any kind of contribution, right? Vorspire, Ravenwolfe, dmurphy22, Ultima-Lokai. If so, good then. I would like to see more contribution from this team in the meaning of bug fixes and new additions.

By the way, there is a hot fix PR in the repo which is waiting for more than 13 hours. https://github.com/ServUO/ServUO/pull/1835

Cheers...

 

@Equinox

You can always just apply the changes yourself. That is what I did for the hot fix with the banners.

 

@Tasanar, thank you for your suggestion. I know what to do but it's not the main idea of my post.

 

@m309 , can you read and understand this?

 

I think @m309 was referring to this statement -

 

@Tasanar , kidding?

 

@m309 , I was thinking about your words. If someone wants to do it, somehow will feel like it and will find a way to create time for it without thinking about to be paid or not. There are good examples like that. If someone doesn't feel like it and/or doesn't want it and/or doesn't have time for it and/or thinking about to be paid or not, what is the purpose/meaning of being an official developer of an open source project which depends on voluntarily contributions?

@Vorspire , It's your choice and didn't surprised me. Is there any management in this project? Sorry didn't aware of it, my mistake. Your attitude were awesome in your original post by the way

I don't know C#, I don't have development environment for it, I don't have development knowledge on ServUO. In this circumstances I've already sent a few commits to repo. They are not big or not important but I'm trying to help as much as I can in this situation. https://github.com/ServUO/ServUO/commits?author=bsenyuva

--- Double Post Merged, Mar 7, 2017 ---

It's good to see that you've changed your description and attitude a bit about reviews Hot fix PR reviewed and accepted at the end of 19 hours, congrats. https://github.com/ServUO/ServUO/pull/1835

 

@Vorspire , your words were "I don't intend to review any PR's until the latest slew of issues has been resolved." while I'm writing my previous reply. Then you added ", which means that PR's with bug fixes are priority over content." part. I wish we are able to see edit history of your posts. I'm not trying to change your behavior or I didn't mean I've changed it. Why do you say that?

You are right, English is not my first language, but I think my words are enough to express my thoughts. Nope, I'm not trying to be sarcastic or facetious.

Let me try to explain with different words. I would like to see more active official developers in this project. Because Dexter is alone and needs help to solve bugs. I can understand that he is mainly responsible for his contributions but there are bugs can be solved by other official developers. For example, I was reported a bug about Lord Oaks, it's a very old mistake and can be solved by any experienced developer. I'm observing there are many official developers being online in forums but almost no one helping him. In my opinion, if someone have time to spend in forums or review PRs, he can solve bugs also. Am I wrong?

I'm supporting any effort in the name of doing things right, I've told already. Specially 3rd feature is very important. In addition as official developers or "management" whatever, you need to encourage new contributors to fix bugs or add content by being example and act as mentors. Not just as rulers. There is a positive motivation appeared recently with contributions of especially Dexter and Argalep. Please be supportive to keep it alive, help them.

 

I've said I don't know C#, because I've got training about it but didn't used in a project. I didn't said I'm new to project management or software development. I'm working in software development sector for 17 years (mostly Java) and last 8 years in management roles. I now what is project management. It means planning tasks, cooperation and communication between members basically. I can't see a project plan, just a sentence "We will clear bugs first then add content". It's a motto. What are the goals for 2017? What will happen when Dexter gone for an uncertain time as he said? Who will be take the responsibility of solving bugs? So where is the project management?

I'm talking about what I see in the last 11 months. I think 11 months is not a short time to classified as new. I was reporting the bugs to our shard owner Argalep first. Than decided to report it directly to ServUO to parallelization of the solving process for speed up. There was many PRs waiting for a long time in the repo at the beginning. If you don't review/accept/reject contributions, what is the purpose of freedom to contribute? I saw Ravenwolfe was active for a little time but there was Dexter mostly and he did great. He reviewed PRs and accepted/rejected/guided them according to their situations and project gained a momentum. Argalep did great contributions also. I know Dexter was helping him about what to do or not in ServUO, was appreciating for good contributions. This is the meaning of mentoring. I'm not talking about answering "How to" questions in forum. Being an official developer requires more than that.

Everybody has their own projects, their own jobs and their own life. It's not an excuse, it's a reality. I'm not ignoring any old contributions. I wasn't asking "Why you are not contributing?", I was inviting the official devs to contribute more in my first post if they have time and experience to review any kind of contribution.

1. Dexter needs help. Maybe needs a backup.
2. You've added a new control layer to contributions. A hot fix from an official developer waited for 19 hours to be reviewed. Hmm.
3. It will be demotivate the people who want to contribute if you act as an elite group who just rules the project instead of supporting/motivating/mentoring/being example to new contributors.

This is what it seems as an outsider. Please accept it as an objective critique from a fan of ServUO project, not demands/judging of a new and inexperienced person who embraces just his assumptions. Maybe you and other official devs are not happy with my words but this is the reality of ServUO project.

 

I like this approach. I remember when RunUO was testing factions for the first time. God it was slow but when it was released to the public it was one hell of a product. I think most of the community is on board with quality over quantity.