@Vorspire , god help ServUO fans then.
I wasn't critique persons with name and what they've done or not or mistaken. Nobody is perfect. Not me nor Argalep nor Dexter nor you. You had a chance in anytime before this system for months to warn him or suggest a PR comment format via PM, you didn't. He was trying to contribute something didn't done by others. Maybe he did mistakes as anybody can. But it's better to make mistakes and correcting it rather than doing nothing.
If there was a project management you knew who did what, why and when. We can see who did what and when approximately, thanks to the GitHub.
Tip: You can select a range to limit on the timeline at the top.
You can be an admin but you have no right to say "If these changes in the way thing are going to be done are unacceptable to you, then I do not know what to say other than, tough. If you feel you must be discouraged by this, then move on.". You don't own this community, project, codes whatever, you are just part of it.
Argalep doesn't care about being in the ServUO organization or not. He just want to give something back to where he get something.
Quality over quantity, exactly... You and other officials are free to contribute with top quality to being good examples in anytime...
@Tasanar , as I remember you were suggesting to apply the fix as is before review
I'm resending my old post with some edit, it was trimmed. I've added something, removed something.
I'm saying again and again. I'm not against any effort in the name of doing things right and/or better. It includes this wall of protection. It's not a good practice to say that "We've changed the rules, obey". You need to show to the people by good examples. I was suggested some thoughts many months ago. Whatever.
Anybody (including officials), if you have time and experience, please help to active developers. Cheers...
@dmurphy , It's a good start, I think it should be better if supported with document about coding standards for ServUO. Then SonarQube can be used to check code quality, compliance with coding standards.
Maybe someday we can use Jenkins for automated continuous integration, who knows
Well before ya'll sit down and start getting angry or questioning the motives of the staff of servuo on why there going this way why not take a look and see that there's still 602 issues sitting in GitHub for the code, adding more content all the time is just adding to that and nothing is actually getting fixed.
Really, 3 days? That PR that caused the compile error was merged a couple hours ago. I have been downloading and testing the bigger ones but for the smaller like the one in question, if they look good it's merged. It's a small oversight on my part.