Fixed method overload issue


Jun 24, 2016
Operating System
Ubuntu 16.06
Mono version if not using windows.
Core: Compiled for MONO and running on (tarball Thu Apr 11 09:09:21 UTC 2019)
ServUO Version
Version 0.5, Build 7116.2620 - Build on 6/26/2019 1:27:20 AM UTC - Release
What were you doing at the time of the crash on your shard:
Compiling it.

There's a problem here line 868 of Services/Craft/DefBlacksmithy.cs is attempting to make a call to AddCraft with 10 arguments. The only accommodating method for this would be the one on line 320 of CraftSystem which accepts 10 arguments but the 4th is a SkillName. It's being passed 0.0 (a double).

I believe that likely the 0.0, 15.0, 70.0 should just be 15.0, 70.0. Someone who understand this stuff more than me should probably confirm though. :D

Errors: + Services/Craft/DefBlacksmithy.cs:    CS1502: Line 868: The best overloaded method match for `Server.Engines.Craft.CraftSystem.AddCraft(System.Type, Server.TextDefinition, Server.TextDefinition, Server.SkillName, double, double, System.Type, Server.TextDefinition, int, Server.TextDefinition)' has some invalid arguments    CS1503: Line 868: Argument `#4' cannot convert `double' expression to type `Server.SkillName' Scripts: One or more scripts failed to compile or no script files were found.


ServUO Developer
Dec 4, 2014
Western New York State
Shard Name
Test Center
Donate money to this user
You are correct. The minimum skill is 15 so the 0.0 should not be there at all. It is an extra parameter.

Note, this will only be found if someone is running the Endless Journey expansion on their server.