1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Outside SVN support

Discussion in 'General Discussion' started by Tasanar, Nov 4, 2017.

  1. Tasanar
    Online

    Platinum Donator

    Joined:
    Oct 16, 2014
    Messages:
    2,538
    Likes Received:
    76
  2. Dexter_Lexia
    Offline

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    2,347
    Likes Received:
    107
    Yea, I tagged Vorspire and Murph on there, I'd prefer to only look at the game play stuff. There are some other pull requests sitting in there that seem pretty good, but I'm not one to say harr harr.
     
  3. PyrO
    Offline

    PyrO Active Member

    Joined:
    Jan 27, 2015
    Messages:
    753
    Likes Received:
    36
    Here is my view on that based on a quick view.

    V3070:
    These are static variables, the order shouldnt throw an error/warning in the first place.
    V3074:
    Hmm not sure about those
    V3093:
    Sure seemed more like a typo that was copy & pasted. Not much gained but doesnt hurt to change to && at all.
    Therefor should be implemented :)
     
  4. Vorspire
    Offline

    Vorspire Vita-Nex: Core
    Admin ServUO Developer

    Joined:
    Jul 29, 2013
    Messages:
    901
    Likes Received:
    165
    I left my review.
     
Similar Threads: Outside SVN
Forum Title Date
Archived Bug Reports Guard kills outside of guarded region Jun 23, 2017
Archived Bug Reports Missing Nightmare Spawn outside of Umbra Mar 22, 2016
Archived Bug Reports Shadow wisp familiar crash - running newest SVN Oct 21, 2017
Archived Bug Reports Newest SVN crash - 7/19/2017 Jul 19, 2017
Archived Bug Reports Some mondain legacy quests bugged since newest svn applied. Jun 27, 2017
Issues Issue with latest SVN and vendor Jun 4, 2017
Support Newest SVN 2/20/2017 - breaks VNC Feb 20, 2017