1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Outside SVN support

Discussion in 'General Discussion' started by Tasanar, Nov 4, 2017.

  1. Tasanar
    Offline

    Moderator ServUO Developer

    Joined:
    Oct 16, 2014
    Messages:
    4,390
    Likes Received:
    95
  2. Dexter_Lexia
    Offline

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    3,672
    Likes Received:
    145
    Yea, I tagged Vorspire and Murph on there, I'd prefer to only look at the game play stuff. There are some other pull requests sitting in there that seem pretty good, but I'm not one to say harr harr.
     
  3. PyrO
    Offline

    PyrO Active Member

    Joined:
    Jan 27, 2015
    Messages:
    973
    Likes Received:
    53
    Here is my view on that based on a quick view.

    V3070:
    These are static variables, the order shouldnt throw an error/warning in the first place.
    V3074:
    Hmm not sure about those
    V3093:
    Sure seemed more like a typo that was copy & pasted. Not much gained but doesnt hurt to change to && at all.
    Therefor should be implemented :)
     
  4. Vorspire
    Offline

    Vorspire Vita-Nex: Core
    Admin ServUO Developer

    Joined:
    Jul 29, 2013
    Messages:
    1,070
    Likes Received:
    192
    I left my review.
     
Similar Threads: Outside SVN
Forum Title Date
Windows Support unable to log into server from outside network Nov 30, 2018
3rd Party Discussions Just curious anyone can script outside UO? Mar 13, 2018
Archived Bug Reports Guard kills outside of guarded region Jun 23, 2017
Archived Bug Reports Missing Nightmare Spawn outside of Umbra Mar 22, 2016
Archived Bug Reports Latest SVN error Friday at 6:15 AM
Archived Bug Reports Animal Taming problems after latest SVN changes Jul 28, 2018
Archived Bug Reports StackOverflow error - newest SVN Jul 1, 2018