Fixed Pet AOE and other group pets effect

LordFenris

Knight
Jul 21, 2014
549
22
18
43
Operating System
Windows Server 2019
ServUO Version
Latest Github
During the last event on our server, we revealed that if a pet (owned by group player) uses the AOE effect, it also affects the pets of other grouped players - as a result, the pet owner receives the status of a criminal and the both pets start fight among themselves.

It is as if the players' pets are not included in the analysis of acceptable AOE targets within the group (as long as other players in the group are not receiving AOE effects, their pets do).

The observations so far show that the problem does not concern the pets of characters remaining in the common guild.
 

Dexter_Lexia

Admin
ServUO Developer
Jul 3, 2014
4,137
208
63
44
USA
Shard Name
Heritage
Donate
Donate money to this user
A couple questions before i debug this.

1. Are you in a fel ruleset?
2. Are the pets masters in a part/guilded
3. What is the notoriety of the pets masters, ie red, criminal, etc.
 

LordFenris

Knight
Jul 21, 2014
549
22
18
43
1. We discovered the problem in the desert near Compassion in Felucca
2. Both players were grouped (party). The owner of the pet throwing AOE is not affiliated with the guild. The second player (whose pet reacted to the attack) was a guild member.
3. The pet owner who threw the AOE was blue as was his pet. The situation was the same for the owner of the second pet (both blue). After AOE was cast, both - the pet thrower and pet owner - were given criminal status. The status of the second player and his pet (affected by the AOE) has not changed (still blue)
 

Dexter_Lexia

Admin
ServUO Developer
Jul 3, 2014
4,137
208
63
44
USA
Shard Name
Heritage
Donate
Donate money to this user
This is not happening for me. Please make sure line 585 of SpellHelper.cs reads this:

Code:
        public static bool IsGuildAllyOrParty(Mobile from, Mobile to)
        {
            return IsGuild(from, to) || IsParty(from, to);
        }
 

LordFenris

Knight
Jul 21, 2014
549
22
18
43
Weird, we don't have any changes to Spellhelper except for changing the ruleset for parts of continents other than Felucca. Hmmmm
Post automatically merged:

Is it possible that the problem may be related to an active Siege Ruleset?
Post automatically merged:

Also our DetectHidden file is exactly the same as in the newest Git.
 
Last edited:

Dexter_Lexia

Admin
ServUO Developer
Jul 3, 2014
4,137
208
63
44
USA
Shard Name
Heritage
Donate
Donate money to this user
It shouldnt, because fel on siege should be treated just like fel on regular servers.
 

Falkor

Squire
Apr 11, 2018
415
158
43
wpshard.com
Shard Name
Whispering Pines
Damage/no damage (as well as CanBeBeneificial) decisions get made in Notoriety.cs so compare that file as well!
 

LordFenris

Knight
Jul 21, 2014
549
22
18
43
@Tasanar
At the moment, after last code addes, both party/pet AOE and unhiden are working fine. We are still waiting for a test report from last one player who had previously problematic insights on this topic .
Thanks :)