1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Players in VvV can not heal their pets

Discussion in 'Archived Bug Reports' started by Tasanar, Jan 11, 2017.

  1. Tasanar
    Offline

    Platinum Donator

    Joined:
    Oct 16, 2014
    Messages:
    2,416
    Likes Received:
    73
    Tested and confirmed.


    Join VvV

    Add a Cusidhe, set his hitpoints to 2

    Set as a player

    Tried to use bandages

    "you cannot perform beneficial acts on your target"

    Did a restart, still same message.
     
  2. Tasanar
    Offline

    Platinum Donator

    Joined:
    Oct 16, 2014
    Messages:
    2,416
    Likes Received:
    73
    What script do I need to look at to change this?

    I thought in Bandage.cs but I could not find it there. Just need to know the script and I will fix.
     
  3. Dexter_Lexia
    Online

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    1,900
    Likes Received:
    92
    I need to look at this at home. I didn't think any of the vvv stuff changed the way beneficial acts was concerned.
     
  4. Tasanar
    Offline

    Platinum Donator

    Joined:
    Oct 16, 2014
    Messages:
    2,416
    Likes Received:
    73
    Okay thanks for the response. I tested myself on a VvV player and it wouldn't let me heal my pet the 2nd I joined.

    I looked at Bandage.cs and Notoriety.cs but nothing really stood out.
     
  5. Dexter_Lexia
    Online

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    1,900
    Likes Received:
    92
    Can you heal guild mates? What about enemies?
     
  6. Tasanar
    Offline

    Platinum Donator

    Joined:
    Oct 16, 2014
    Messages:
    2,416
    Likes Received:
    73
    I know we have about 15 active members in VvV going around daily taking the alters and such.

    None of them have reported issues.

    But I've also not tested those two scenarios myself.

    How does it determine Vice or Virtue?

    Is it by your fame/karma?
    --- Double Post Merged, Jan 12, 2017 ---
    If so maybe the owner is "bad" and the pet is "good" based on fame / karma?
     
  7. Dexter_Lexia
    Online

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    1,900
    Likes Received:
    92
    I am able to, weird.
     
  8. Tasanar
    Offline

    Platinum Donator

    Joined:
    Oct 16, 2014
    Messages:
    2,416
    Likes Received:
    73
    set your fame and karma to evil?
    --- Double Post Merged, Jan 12, 2017 ---
    Also something else players reported which I can see.

    Sometimes YOUR pet will go orange...when you try to heal you get

    V

    SHOWWWWWWWWWWW.png
    --- Double Post Merged, Jan 12, 2017 ---
    Even when I click okay I get this

    SHOW1.png


    my players too, report not being able to heal their pets. I invite you on to see. No edits, NEWEST svn.
    --- Double Post Merged, Jan 12, 2017 ---
    As STAFF in VvV he stays grey and I can heal

    Corgul soulbinder.png

    As a PLAYER he turns orange like me IF IN FELUCCA or blue if in a trammel facet, but regardless can not heal.
     
  9. Dexter_Lexia
    Online

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    1,900
    Likes Received:
    92
    I cannot reproduce this. The issue is, they are turning orange. I cannot get any pets to turn orange.
     
  10. Dexter_Lexia
    Online

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    1,900
    Likes Received:
    92
    Fame/karma has nothing to do with it. They are only orange if they are vvv (or in this case, the control master) and they are in another, non allied guild.

    Vice and virtue really have nothing to do with combat. No guild declares any type of loyalty to vice or virtue. It seems like an unfinished system that EA rolled out.
     
  11. Tasanar
    Offline

    Platinum Donator

    Joined:
    Oct 16, 2014
    Messages:
    2,416
    Likes Received:
    73
    I have 0 edits to any code. I keep my shard almost strictly svn. It has to be something. Any tamer in VvV can not heal his pets.
    --- Double Post Merged, Jan 13, 2017 ---
    Also something else I don't get,

    When I test VvV I make my own guild and join.

    There is another big VvV guild on the shard. When I go to an alter they are at half will appear blue and half will appear orange...why is this?
    --- Double Post Merged, Jan 13, 2017 ---
    That's why I thought maybe their fame or karma declared one evil and one good.
    --- Double Post Merged, Jan 13, 2017 ---
    Screenshot_20170113-091912.png

    It seems to be some players randomly turn orange and some blue, even in the same guild, all in VvV.
    --- Double Post Merged, Jan 13, 2017 ---
    @Dexter_Lexia - for now id like to just kick everyone from VvV and disable it. What is the best way to do that.
    --- Double Post Merged, Jan 13, 2017 ---
    Code (C#):
    1.  public class ViceVsVirtueSystem : PointsSystem
    2.     {
    3.         public static int VirtueHue = 2124; //TODO: Get
    4.         public static int ViceHue = 2118; //TODO: Get
    5.  
    6.         public static bool Enabled = true;
    7.         public static ViceVsVirtueSystem Instance { get; set; }

    If I change true to false will it also remove the option from the guild menu and delete all the VvV items?
    --- Double Post Merged, Jan 13, 2017 ---
    SHOWWWW.png


    I had him try multiple pets.

    Set their hits to 10

    could not heal :(
    --- Double Post Merged, Jan 13, 2017 ---
    Its not all tamers. Today also when I tested again it turned me and my pet green. It seems it has a small chance to turn some orange or make enemy?
     
  12. Dexter_Lexia
    Online

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    1,900
    Likes Received:
    92
    Props the pets. Make sure the pets have controlled set to true, and that controlmaster is set to thier owner. I'm looking over notoriety.cs for any issues. Are these issues arising well after they've joined vvv? Or is it happening right after joining?
     
  13. Dexter_Lexia
    Online

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    1,900
    Likes Received:
    92
    And just to be sure, they are trying to heal thier own pets, or allied pets?
     
  14. Tasanar
    Offline

    Platinum Donator

    Joined:
    Oct 16, 2014
    Messages:
    2,416
    Likes Received:
    73
    They can't remember. They joined and then couldn't heal after.

    I did that, eveb had him stable and cycle pets to show
    --- Double Post Merged, Jan 13, 2017 ---
    Their own pet


    Now how does it know to turn others orange? Is it on facet change? Maybe declaring VvV in malas and then going to fel sometimes makes them tagged as enemy.

    I can reproduce it but not eveytime. So weird
    --- Double Post Merged, Jan 13, 2017 ---
    I would guess right after joining.

    Last night i joined and went orange, i sent those screen shots above. The 2nd time i joined, that time i went green and so did my pet
     
  15. Dexter_Lexia
    Online

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    1,900
    Likes Received:
    92
    Notoriety changes for VvV only apply in fel. So anywhere besides fel should be normal.
     
  16. Dexter_Lexia
    Online

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    1,900
    Likes Received:
    92
    I have a theory. And it may be an issue that COULD arise when you quit a guild and rebuild while in the waiting period. Unfortunately, I can't get at it until I get home.
     
    • Like Like x 1
  17. Dexter_Lexia
    Online

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    1,900
    Likes Received:
    92
    Ok, try the new repo and let me know.
     
    • Like Like x 1
  18. Tasanar
    Offline

    Platinum Donator

    Joined:
    Oct 16, 2014
    Messages:
    2,416
    Likes Received:
    73
    Yeah which is weird because it does seem to restrict him in Malas

    Awesome thanks! Ill be home in an hour or two. I'll let you know right away. Really appreciate you entertaining this without being able to reproduce.
    --- Double Post Merged, Jan 13, 2017 ---
    So far everything seems to work man! That player no longer has an issue healing their pet.

    I will let you know in a future bug report if any issues arise with notoriety, pets, and players in regards to VvV.

    For now I can say this bug report seems to have been resolved.
     
  19. Dexter_Lexia
    Online

    Moderator ServUO Developer

    Joined:
    Jul 3, 2014
    Messages:
    1,900
    Likes Received:
    92
    It's related to the earlier bug. The data that stores a players vvv stuff has a guild property that was coming back null. Since a later discovery was made that vvv membership doesn't matter what guild your in, just that you be in a guild, the property can be removed and guild membership can be checked realtime.
     
    • Like Like x 1
  20. Tasanar
    Offline

    Platinum Donator

    Joined:
    Oct 16, 2014
    Messages:
    2,416
    Likes Received:
    73
    Awesome! Thanks for all your help.
     
    • Like Like x 1
Similar Threads: Players VvV
Forum Title Date
Archived Bug Reports After a VvV war in Felluca players seems criminal to each other in Malas Jul 23, 2017
Archived Bug Reports no VvV players counting as VvV guilds in Battle Feb 3, 2017
Archived Bug Reports Conflagration potion doesn't give damage to players Jul 28, 2017
Archived Bug Reports If you try to track gargoyle players = see inside Jul 9, 2017
Archived Bug Reports Players are able to customize item names with HTML Jul 8, 2017
Script Support Invisible Tiles that Still affect players Jul 2, 2017
Archived Bug Reports Players farming virtue artifacts for clean up points by spamming champ lower spawns. Jun 19, 2017