1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Fixed Resmelting Colored blacksmith items

Discussion in 'Archived Bug Reports' started by Tasanar, Jul 11, 2018.

  1. Tasanar
    Offline

    Moderator

    Joined:
    Oct 16, 2014
    Messages:
    4,273
    Likes Received:
    93
    Originally reported by a player on UO Heritage:

    http://www.uoguide.com/Mining states that recycling items should use either blacksmithing or mining, whichever is greater:

    Ingot Return from Recycling Blacksmithy Items
    Recycling items requires a Blacksmithy tool, a forge and an anvil. The amount of ingots returned is based on the greater of the characters mining OR blacksmithing skill, as follows:

    • When re-smelting blacksmith items, the skill check uses the greater of the character’s Mining or Blacksmith skills (capped at 105)
    • The amount of ingots returned is calculated by the following formula: (ingots needed to make item) x (0.66% x Skill), rounding fractions down after the multiplication is done. At 100.0 skill, a 12-ingot item will return 7 ingots (12 x 66.0%, rounded down).
    • To get 2/3 your ingots (66.67%) back when Recycling, one must have at least 101.1 skill (natural skill plus the bonus from either +3 or +5 Mining Gloves )

    However, the code is only checking mining
    https://github.com/ServUO/ServUO/blob/master/Scripts/Services/Craft/Core/Resmelt.cs
    if (difficulty > from.Skills[SkillName.Mining].Value) return SmeltResult.NoSkill;

    After doing more research this does seem to be the case.

    So, this might need to be modified with an OR blacksmithing check.
     
  2. Tasanar
    Offline

    Moderator

    Joined:
    Oct 16, 2014
    Messages:
    4,273
    Likes Received:
    93
    So I approved the current change but it says the skill value for both should be capped at 105. I didnt see that in there. I think they do this since you can only get to 105 mining. At 120 blacksmith currently you'd get more ingots back, it should be capped at 105.
     
Similar Threads: Resmelting Colored
Forum Title Date
Archived Bug Reports Tinker Bods - colored tool kits Jul 18, 2018
Archived Bug Reports Colored Order and Blue Marlin Trophy May 14, 2018
Art The Expanse Colored Icons May 19, 2017
Script Support Colored item name (Aos disabled) May 1, 2017
Core Modifications Colored Lights Feb 8, 2017
Archived Bug Reports Enhancing weapons with partially elemental damage using colored ingots Nov 30, 2016
Script Support Colored String msg? Sep 28, 2016