Fixed Server Crash - When getting close to a map location

nibirugod

Citizen
May 31, 2018
17
2
3
Operating System
Ubuntu - Operating System: Unix 4.4.0.1105
Mono version if not using windows.
Mono JIT compiler version 5.12.0.301
ServUO Version
ServUO Version 0.5, Build 7446.27931
Does anyone get an idea of what may be happening by looking at this exception?

This may not be a bug!

If this is a crash report please paste your crash report in the following code tags:
Code:
Server Crash Report
===================

ServUO Version 0.5, Build 7446.27931
Operating System: Unix 4.4.0.1105
.NET Framework: 4.0.30319.42000
Time: 5/22/2020 4:16:55 PM
Mobiles: 47096
Items: 317289
Exception:
System.NullReferenceException: Object reference not set to an instance of an object
  at Server.Items.MooringLine.get_LabelNumber () [0x00006] in <3df9106992a348c5b1f2328d6c1b4322>:0 
  at Server.Item.AddNameProperty (Server.ObjectPropertyList list) [0x0002a] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Item.AddNameProperties (Server.ObjectPropertyList list) [0x00000] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Item.GetProperties (Server.ObjectPropertyList list) [0x00000] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Item.get_PropertyList () [0x00017] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Item.get_OPLPacket () [0x00027] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Item.SendInfoTo (Server.Network.NetState state, System.Boolean sendOplPacket) [0x00013] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Item.SendInfoTo (Server.Network.NetState state) [0x00018] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Mobile.SetLocation (Server.Point3D newLocation, System.Boolean isTeleport) [0x0024a] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Mobiles.PlayerMobile.SetLocation (Server.Point3D loc, System.Boolean isTeleport) [0x0005c] in <3df9106992a348c5b1f2328d6c1b4322>:0 
  at Server.Mobile.Move (Server.Direction d) [0x00742] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Mobiles.PlayerMobile.Move (Server.Direction d) [0x00069] in <3df9106992a348c5b1f2328d6c1b4322>:0 
  at Server.Network.PacketHandlers.MovementReq (Server.Network.NetState state, Server.Network.PacketReader pvSrc) [0x0002d] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Network.MessagePump.HandleReceive (Server.Network.NetState ns) [0x00240] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Network.MessagePump.Slice () [0x00057] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0 
  at Server.Core.Main (System.String[] args) [0x006e6] in <6dbac9c7c8994e2f85d766e8a4db0aad>:0
What were you doing at the time of the crash on your shard: My server is crashing whenever people get close to the dock in Isamu, where the Travesty box is. Sorry I don't have much more details about.

If this thread is to report an inaccuracy with ServUO's systems please tell us to the best of your ability why you believe so: n/a

Please paste any relative online material that will help prove the inaccuracy:
 

shiker86

Citizen
May 19, 2020
8
0
1
The server crash when a player approaches the Isamu dock, where the Travesty is. You don't need to enter the dungeon, just by being close to the area. It is also not related to the quest that allows access to the dungeon, since it crashes with or without it.
Post automatically merged:

I add one more data. The server was upgraded from Publish 55 to Publish 57, maintaining the "TOL" era. In doing so the galleons disappeared. It is possible that a galleon has been in that zone before, and when updating it has been erroneously deleted being the cause of the error. Is there a command to remove all boats from the water?
 
Last edited:

PyrO

Paladin
Jan 27, 2015
1,294
156
63
Issue there is that Boat is null. And that there are 2 null checks missing

That line should be changed to
C#:
public override int LabelNumber => Boat == null || Boat.IsRowBoat ? 1020935 : 1149697;
in that case it will at least be named Rope even if the Boat doesnt exist anymore

And here it should be
C#:
if (Boat != null && Boat.IsRowBoat && from.Alive && !Boat.Contains(from))
to not further crash the server in case someone tries to open the context menu of the rope / mooring line
 
  • Like
Reactions: shiker86

nibirugod

Citizen
May 31, 2018
17
2
3
Hey @PyrO ,

Thanks for the quick reply. I just changed those 2 lines and I'm letting our community to try this out again. I'll let you know if the issue persist, but I don't think it will.

I really appreciate your support with this.

Best,