servuo harvesting stone and gems server crash

[rhasce]

Hi all,

A user manage to crash server today and he can reproduce, very simple crash he reported whats on the title, but this is his full sentence : (using pickaxes, but as soon as i read the book for mining for quality gems, set to mine for ore and gems and start mining.. the server crashes)

Any assistance? I sort of don't even know where to start looking to fix this

also I started my server with this repack https://www.servuo.com/archive/servuorepack.803/update?update=1170

this is my crash logs there were 2 files

ServUO Version 0.5, Build 6591.36173
Operating System: Unix 4.9.0.5
.NET Framework: 4.0.30319.42000
Time: 1/28/2018 2:59:27 PM
Mobiles: 158452
Items: 1663901
Exception:
System.NullReferenceException: Object reference not set to an instance of an object
at daat99.ResourceHelper.GetDaat99HarvestedType (System.Type originalType, System.Boolean prospected, System.Double skill) [0x000ed] in <72b34ced7f4b40ea88650db354ad19b5>:0
at Server.Engines.Harvest.HarvestSystem.FinishHarvesting (Server.Mobile from, Server.Item tool, Server.Engines.Harvest.HarvestDefinition def, System.Object toHarvest, System.Object locked) [0x00225] in <72b34ced7f4b40ea88650db354ad19b5>:0
at Server.Engines.Harvest.HarvestSoundTimer.OnTick () [0x0002e] in <72b34ced7f4b40ea88650db354ad19b5>:0
at Server.Timer.Slice () [0x00047] in <d8531c84ee7a46c79a697038fdef61b0>:0
at Server.Core.Main (System.String[] args) [0x0056c] in <d8531c84ee7a46c79a697038fdef61b0>:0


ServUO Version 0.5, Build 6591.36173
Operating System: Unix 4.9.0.5
.NET Framework: 4.0.30319.42000
Time: 1/28/2018 2:40:11 PM
Mobiles: 158393
Items: 1665605
Exception:
System.NullReferenceException: Object reference not set to an instance of an object
at daat99.ResourceHelper.GetDaat99HarvestedType (System.Type originalType, System.Boolean prospected, System.Double skill) [0x000ed] in <72b34ced7f4b40ea88650db354ad19b5>:0
at Server.Engines.Harvest.HarvestSystem.FinishHarvesting (Server.Mobile from, Server.Item tool, Server.Engines.Harvest.HarvestDefinition def, System.Object toHarvest, System.Object locked) [0x00225] in <72b34ced7f4b40ea88650db354ad19b5>:0
at Server.Engines.Harvest.HarvestSoundTimer.OnTick () [0x0002e] in <72b34ced7f4b40ea88650db354ad19b5>:0
at Server.Timer.Slice () [0x00047] in <d8531c84ee7a46c79a697038fdef61b0>:0
at Server.Core.Main (System.String[] args) [0x0056c] in <d8531c84ee7a46c79a697038fdef61b0>:0

 

[Po0ka]

Search in there:
daat99.ResourceHelper.GetDaat99HarvestedType (System.Type originalType, System.Boolean prospected, System.Double skill)

There must be a null check missing or something.

 

[rhasce]

Thanks mate still looking dont see anything apparent, this is most info I find on this some guy have exact same error
[doublepost=1517198461][/doublepost]Found this seems to fix my problem:

Scripts/Services/Harvest/Core/HarvestSystem.cs Modified

View file





if (daatHarvesting)

{

type = ResourceHelper.GetDaat99HarvestedType(type, bank.Vein.IsProspected, skillValue);

+ //type = GetResourceType(from, tool, def, map, loc, resource); <<<<<<-----Commented out this

from.CheckSkill(def.Skill, 0.0, from.Skills[def.Skill].Cap + (vein.IsProspected?10.0:0.0));

}

//daat99 OWLTR end - daat99 harvesting



if (type != null)

{

Item item = Construct( type, from );



if (item == null)

{

type = null;

}

else