1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

StoneForm

Discussion in 'Archived Bug Reports' started by Regnak, Oct 30, 2013.

  1. Regnak
    Offline

    Regnak Active Member

    Joined:
    Apr 1, 2013
    Messages:
    254
    Likes Received:
    43
    Hey !

    I just wanted to report that StoneForm is still bugged in Publish 54. I thought the new Tick system would correct it, but it seems still bugged.

    Behavior : the mali from casting the spell don't remove fast enough. If you cast the spell several times, you find yourself not being able to cast or swing at all...

    Temp fix : I use another version of StoneForm.cs (I found on CraftUO.com but I can upload it here as soon as I have a computer below my hands :p )

    Thank you !

    -Rek-
     
    • Agree Agree x 1
  2. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,105
    Likes Received:
    117
    Dunno if this is the same one you have but this one is working according to OSI standards...
     

    Attached Files:

    • Like Like x 1
    • Two Thumbs Up Two Thumbs Up x 1
  3. Ziru
    Offline

    Ziru New Member

    Joined:
    Oct 26, 2013
    Messages:
    17
    Likes Received:
    1
    what to do with bugged characters?
    killing them and res them don't solve the bugged status.
     
  4. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,105
    Likes Received:
    117
    I never had the issue, can you explain what is stuck on them? Is it the swing speed or what?
     
  5. Regnak
    Offline

    Regnak Active Member

    Joined:
    Apr 1, 2013
    Messages:
    254
    Likes Received:
    43
    The bugged chars get a negative cumulative counter ... that wears off after a loooong time.

    Indeed, it effects swing speed and faster cast (mali from using Stone Form).

    Your version works fines ! We should use that one ;)
     
  6. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,105
    Likes Received:
    117
    Hmm, will be hard to remove the effects that are already on characters. You would have to write a separate script with a method to pull those changes off. Might be better to let the effects wear off by time.

    That does bring up an issue, perhaps we should set the stone form effects to automatically wear off on death? That would work for future players as well as debugging current ones.
    --- Double Post Merged, Nov 1, 2013, Original Post Date: Nov 1, 2013 ---
    Ok, try this. Probably an edit we should have anyway.

    Go to PlayerMobile. At the top lines where the using directives are, add using.Server.Spells.Mystic;


    Code (C#):
    1. using Server.Spells.Sixth;
    2. using Server.Spells.Spellweaving;
    3. using Server.Spells.Mystic;
    4. using Server.Targeting;
    Then go to the OnDeath Method and look for:

    Code (C#):
    1. PolymorphSpell.StopTimer(this);
    2. IncognitoSpell.StopTimer(this);
    3. DisguiseTimers.RemoveTimer(this);
    4.  
    5. EndAction(typeof(PolymorphSpell));
    6. EndAction(typeof(IncognitoSpell));
    Add this line at the end of it so that it looks like this:

    Code (C#):
    1. PolymorphSpell.StopTimer(this);
    2. IncognitoSpell.StopTimer(this);
    3. DisguiseTimers.RemoveTimer(this);
    4.  
    5. EndAction(typeof(PolymorphSpell));
    6. EndAction(typeof(IncognitoSpell));
    7. StoneFormSpell.RemoveEffect(this);
    This should cause the negative effects to be removed when they die. So just kill any currently bugged characters and they should be de-bugged.

    I dont have any bugged characters so I cant test, but I did kill myself and it removed the stone form effects, so please try this and let me know.
     
  7. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,105
    Likes Received:
    117
    Someone please test and report back on this fix?
     
  8. hutpat
    Offline

    hutpat Member

    Joined:
    Oct 24, 2013
    Messages:
    39
    Likes Received:
    0
    Everything works perfectly
    Ravenwolfe
    cool
     
  9. cmileto
    Offline

    cmileto Member

    Joined:
    Nov 18, 2013
    Messages:
    160
    Likes Received:
    5
    second that just integrated the fix and tested it out, seems very legit.
     
  10. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,105
    Likes Received:
    117
    Thanks!

    @Milva I can't mark these as resolved, guess you get to do it!
     
  11. Regnak
    Offline

    Regnak Active Member

    Joined:
    Apr 1, 2013
    Messages:
    254
    Likes Received:
    43
    Tested and working too :)

    Thx thx !
     
  12. hutpat
    Offline

    hutpat Member

    Joined:
    Oct 24, 2013
    Messages:
    39
    Likes Received:
    0
    Tell me this is normal? Gargoyle mode flying, can use StoneForm?
     
  13. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,105
    Likes Received:
    117
    It should take them out of flying mode, but yes.
     
  14. hutpat
    Offline

    hutpat Member

    Joined:
    Oct 24, 2013
    Messages:
    39
    Likes Received:
    0
    That is not a bug?
     
  15. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,105
    Likes Received:
    117
    Oh, I see now, it keeps them in flying mode, I will fix that.
     
  16. hutpat
    Offline

    hutpat Member

    Joined:
    Oct 24, 2013
    Messages:
    39
    Likes Received:
    0
    Awaiting your correction :)
     
  17. Milva
    Offline

    Admin Moderator

    Joined:
    Mar 3, 2013
    Messages:
    3,434
    Likes Received:
    385
    He might be working today but checking the forums, so give it some time :)
     
  18. hutpat
    Offline

    hutpat Member

    Joined:
    Oct 24, 2013
    Messages:
    39
    Likes Received:
    0
  19. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,105
    Likes Received:
    117
    Yeah, sorry. Im actually out camping and my air card isnt working, only my phone. If i cant get my aircard working, im outta commission until sunday, sorry.

    If someone else wants to, all it needs is an if statement in the OnCast method to see if they are flying and if they are, just ground them before casting.
     
  20. cmileto
    Offline

    cmileto Member

    Joined:
    Nov 18, 2013
    Messages:
    160
    Likes Received:
    5
    Would something like this be ok?
    Code (C#):
    1.  
    2. public override void OnCast()
    3. {
    4.     if ( CheckSequence() )
    5. {
    6.                 //ground if flying when cast
    7.                 if (Caster.Flying)
    8.                 {
    9.                     Caster.Flying = false;
    10.                 }
    11.  
    12. // Values
    13.                 int bonus1 = 2 + (int)(Caster.Skills[SkillName.Mysticism].Value / 20);
    14.                 int bonus = 1 + (int)(Caster.Skills[SkillName.Focus].Value / 20);
    15.  
    16. // Mount
    17. IMount mount = Caster.Mount;
    18.  
    19. if ( mount != null )
    20. mount.Rider = null;
    21.  
    22. // Resists
    23. List<ResistanceMod> mods = new List<ResistanceMod>();
    24. mods.Add( new ResistanceMod( ResistanceType.Physical, bonus1 + bonus ) );
    25. mods.Add( new ResistanceMod( ResistanceType.Fire, bonus1 + bonus) );
    26. mods.Add( new ResistanceMod( ResistanceType.Cold, bonus1 + bonus) );
    27. mods.Add( new ResistanceMod( ResistanceType.Poison, bonus1 + bonus) );
    28. mods.Add( new ResistanceMod( ResistanceType.Energy, bonus1 + bonus ) );
    29. for (int i = 0; i < mods.Count; i++)
    30. Caster.AddResistanceMod( mods[i] );
    31.  
    32. // Effects
    33.                 Caster.BodyMod = 705;
    34.                 Caster.PlaySound( 0x65A );
    35.                 Caster.FixedParticles( 0x3728, 1, 13, 9918, 92, 3, EffectLayer.Head );
    36.  
    37. m_Table.Add( Caster, mods );
    38.  
    39. Enhancement.SetValue( Caster, AosAttribute.CastSpeed, -2, "Stone Form" );
    40. Enhancement.SetValue( Caster, AosAttribute.WeaponSpeed, -10, "Stone Form" );
    41.  
    42.                 Caster.BeginAction(typeof(StoneFormSpell));
    43. }
    44.              FinishSequence();
    45. }
    46.  
    It seems like it would but I cant try it out till later.
     
    #20 cmileto, Nov 29, 2013
    Last edited: Nov 30, 2013
    • Like Like x 1