Fixed Tools multiproduction bug (incorrect formula)

LordFenris

Squire
Jul 21, 2014
487
13
18
43
Operating System
Windows Server 2019
ServUO Version
Latest Git
I am reporting an interesting topic worth deeper analysis.

The new character (but without the status of a newbie) with 75.7 fishing ability caught fish. These were then processed into steaks. Having about 1000 (raw steaks) using a rolling pin - cooked them simultaneously. During this one-time activity her level of cooking ability increased from about 33 (she learned so much from the NPC) to 100 (increase by over 67) as if accumulating all potential partial gains. The question is, should they really look like this?

I also got the impression that when processing all steaks at once, the indicated tool does not differentiate in any way the chance to increase the skill which looks different when having cooking at 30, 50, 80 and 90+. Thus, with a low skill, if you only have the raw materials you can easily achieve the cap while processing the entire production.

What's more, I also noticed that if, for example, the Player does not immediately process a large amount of raw steaks, but only e.g. takes to the bag only first 10 and counts for them the cumulative gain (e.g. 0.6 points), then when, immediately after this he even processes next 1000 raw steaks (cooked them simultaneously), he won't get any gain. Re-gains will be counted only after some time.

We definitely need to look at the subject.
Post automatically merged:

I suspect that a similar problem may apply to the processing of other raw materials (boards, ore, etc.)
 
Last edited:

LordFenris

Squire
Jul 21, 2014
487
13
18
43
Mass production should not generate such large capacity gains - in one click. Checked today : - with 50 bowcraft on OSI and 125 boards, with one click the character has barely trained up to level 50.5 bowcraft.
At ServUO - 50 bowcraft + 125 boards trained the character up to level 62.5 .
Post automatically merged:

Therefore, definitely multiprocessing of a large amount of materials or mass items production with one click excessively accumulates the increase of skills, which means that with a larger package of resources you are able to get an instant crafting skill cap with one click of the mouse .
 
Last edited:

Dexter_Lexia

Admin
ServUO Developer
Jul 3, 2014
4,067
189
63
43
USA
Shard Name
Heritage
Donate
Donate money to this user
Since your on EA checking this, a greater sample size of trying it once would be very helpful. Maybe you can try it, say 100 times? Maybe there is a cap of how many gains you can get.
 

LordFenris

Squire
Jul 21, 2014
487
13
18
43
Today we will try to test it longer on OSI and let you know what conclusions we came to
 

LordFenris

Squire
Jul 21, 2014
487
13
18
43
So we test miltiproducion with bowcraft/ fukiya (
50 bowcraft skill ( skill value)
1. x100 50.5 (number of boards and gain)
2. x200 50.8
3. x300 51.2
4. x400 50.0
5. x500 50.1

60 skill
1. x100 60.2
2. x200 60.0
3. x300 60.5
4. x400 60.0
5. x500 60.9

70 skill
1. x100 70.1
2. x200 70.2
3. x300 70.2
4. x400 70.4
5. x500 70.4

80 skill
1. x100 80.0
2. x200 80.1
3. x300 80.1
4. x400 80.1
5. x500 80.1

90 skill
1. x100 90.0
2. x200 90.0
3. x300 90.0
4. x400 90.0
5. x500 90.0

x100/200/300/400/500 means number of boards used in one click craft.
 

LordFenris

Squire
Jul 21, 2014
487
13
18
43
And here is a cooking progress (steaks)

20 cooking skill
1. x100 22.1
2. x200 23.9
3. x300 25.8
4. x400 27.6
5. x500 29.5
6. x2000 38.8

30 skill
1. x100 30.0
2. x200 30.0
3. x300 33.5
4. x400 34.6
5. x500 30.0
6. x2000 41.3

40 skill
1. x100 40.0
2. x200 41.4
3. x300 40.0
4. x400 42.6
5. x500 40.0
6. x2000 46.7

50 skill
1. x100 50.0
2. x200 50.7
3. x300 51.2
4. x400 51.5
5. x500 50.0
6. x2000 53.7

60 skill
1. x100 60.2
2. x200 60.0
3. x300 60.7
4. x400 60.0
5. x500 60.0
6. x2000 62.1

x100/200/300/400/500/2000 means number of raw fish steaks used in one click craft.
Post automatically merged:


With skill 70,80,90 - cooking increments with steaks were zero or almost zero (even with a 2k trial) while ServUO having 33 skill and processing 1k raw steaks - with one click you can reach even 100 ( cap) - increase 67 point. Similarly with other crafting skills, and this is a serious problem, because knowing this exploit you will train crafting skills faster than meditation.
 
Last edited:

JGreen

Squire
Jul 16, 2019
180
31
28
I tryed you theroy of a player using just fish steaks to raise skill. Its not possible to gain more skill after you have already x amount of skill

I went ingame added 1000 raw fish steaks created a normal char with 30 cooking skill and got my macro set up and started to cook all the fish steaks i gained only so much skill and after cooking 1000 steaks i didnt get near 100 skill cooking.

so your theroy of a player macroing a skill to a 100 with one item can not happen even the code prevents these.

There is a code check that prevents you to gain skill. Did you edit any of you craft files or have any custom files added that could of caused that to change on your shard.
 

Falkor

Squire
Apr 11, 2018
253
88
28
wpshard.com
Shard Name
Whispering Pines
The bug is that they can put 1000 steaks in their pack and then choose "make max" from the cooking menu. Macroing them one at a time will not do it.

I just tried it starting from a base of 30 cooking skill. It went up a couple of tenths on the first few auto-attempts and then BLAM - instantly 68.8, just on fish steaks. Another 1000 took me to over 89 skill with one click.
 

LordFenris

Squire
Jul 21, 2014
487
13
18
43
Exactly @Falkor

In this regard, we have not made any changes to the craft or custom files. The only correction concerns the reduction of the chance for skill increase after exceeding the next tens of skill points (due to which, as skill increases, another gain is more difficult to obtain, especially at higher levels). Our change is therefore preventive, and yet such large increases - with make max - are taking place.

Looking at the OSI results cited above for the "make max" option, such large increases in processing 1000 steaks (or other raw material) should not take place. For example, above 60 points of cooking, 1000 steaks provided gain of an average of only 1 point, and after exceeding 70 points of cooking, gains were almost none, because steaks are, after all, a basic product, so it would be difficult to make Grandmaster only on them).
 
Last edited:

JGreen

Squire
Jul 16, 2019
180
31
28
Okay so its the Max Create. After trying it you are correct its not performing the skill check it should be to stop skill Gain.

problem is in here

AutoCraftTimer

its got no checks in place

also in the craft f coooking def

here is your fish steak
index = AddCraft(typeof(FishSteak), 1044498, 1022427, 0.0, 100.0, typeof(RawFishSteak), 1044476, 1, 1044253);


0.0 is the Min Skill you can start cooking

100.0 is the max skill means you can gain all the way to 100 on the fish steaks.

If i am readding that correctly i never have dived so deep into the craft system.

So anything set to 100 max skill means you will gain all the way up to 100. Does any one know what the max skill is you can Gain on OSI Servers?

If that Max skill is post to be the Success rate maybe that all needs recoded so the max skill is the max you can gain and the success rate needs to be added?

And here is a post on Uo.stratics about using make max to gain skill using fish steaks


it is post to work the way it is working now.
 
Last edited:

Dexter_Lexia

Admin
ServUO Developer
Jul 3, 2014
4,067
189
63
43
USA
Shard Name
Heritage
Donate
Donate money to this user
One issue is gain chance is highly accelerated on ServUO compared to EA.