Fixing issue where equipment is removed on login

[Iomega0318]

ServUO Version

Publish 57

Ultima Expansion

Endless Journey

So this was fixed for Pub 58 here:

Fixing issue where equipment is removed on login (#4988) · ServUO/ServUO@a6525bd

An Ultima Online server emulator written in C# .NET - Fixing issue where equipment is removed on login (#4988) · ServUO/ServUO@a6525bd

github.com

Is there a way to fix that in Pub 57?

 

[zerodowned]

if there's an issue there then I'd put my money on this
bool morph = from.FindItemOnLayer(Layer.Earrings) is MorphEarrings;

and then checking !morph

because if you check the FindItemOnlayer method it will ONLY return true or null, never false

public Item FindItemOnLayer(Layer layer)
        {
            var eq = m_Items;
            int count = eq.Count;

            for (int i = 0; i < count; ++i)
            {
                Item item = eq[i];

                if (!item.Deleted && item.Layer == layer)
                {
                    return item;
                }
            }

            return null;
        }

So try going through each line of PlayerMobile > OnLogin and find this

else if (weapon.RequiredRace != null && weapon.RequiredRace != Race && !morph)

i believe the easiest change here would be

else if (weapon.RequiredRace != null && weapon.RequiredRace != Race && morph != null)

 

[Iomega0318]

Dang it didn't work I mean I could just fully heal the player on login but I feel like that'd be exploitable..

 

[zerodowned]

Is there a particular item you're checking for?

 

[Iomega0318]

I'm just trying to prevent the player from having to heal when they log in, depending on stats that could be a large amount to recover.. just trying to apply the fix already in place in the new repo to an older version haha..