Dan(Tasanar)

Moderator
This is awesome man thank you!

A great framework to start on. So what ones are disabled right now due to no event sinks?

It looks like Discovery is one of them.
[doublepost=1474738119][/doublepost]Okay so a bug.

Kill 5 dogs restart and BOOM achievement is gone.

After this point can no longer gain that achievement. Tried with both the Achievement memory stone added and removed.
[doublepost=1474738373][/doublepost]Nevermind.

Add stone first,

Restart,

then play around with it.
 

Frosttiger

Citizen
yeah far as I know it saves the tasks but I cant figure out the null crash with the discovery one .

The discovery one works and all. but if a player logs out in any region the shard crashes with a null.
 

sahisahi

Rookie
I get error: im using runuo2.2



KUSTOM/Achievement System/Gumps/AchievementGump.cs:
CS0241: Line 13: Default parameter specifiers are not permitted

This is the method causing the error:

Code:
public AchievementGump(Dictionary<int, AchieveData> achieves, int total,int category = 1) : base(25, 25)


Any clue? thanks
 

Dan(Tasanar)

Moderator
With all the event sinks and stuff too, it has been years since I looked at RunUO. I am sure it can be modified to work but will most likely have to be done by those who use RunUO still.
 

tass23

Moderator
Any scripts can be adapted to work with ServUO. I haven't had time to look at this yet to figure out the null issue, but my guess is never letting it result in a null value is a step in the right direction.

@sahisahi I don't know exactly what is causing your error, but if I have time to look at this system (or anyone else for that matter), I'm sure it can be fixed.
 

PyrO

Moderator
The error just comes from the old version of net framework that is set in runuo 2.2, so the issue is "int category =1". So remove the =1 and I guess you will need to adjust the script further since it may not actually set the category in some places
 

tass23

Moderator
It is a very nice drag and drop system but it needs a little TLC. The gump closes at random ect.
Ha! Yeah, I've run into situations like that with a lot of the old scripts in my archives!

If someone doesn't beat me to it, I'll get around to updating this in the future ;)
 

sahisahi

Rookie
The error just comes from the old version of net framework that is set in runuo 2.2, so the issue is "int category =1". So remove the =1 and I guess you will need to adjust the script further since it may not actually set the category in some places


I did what you said, now im getting 3 errors:


Errors:
+ KUSTOM/Achievement System/AchieveTypes/DiscoveryAchievement.cs:
CS0246: Line 33: The type or namespace name 'OnEnterRegionEventArgs' could n
ot be found (are you missing a using directive or an assembly reference?)
+ KUSTOM/Achievement System/AchieveTypes/HarvestAchievement.cs:
CS0246: Line 17: The type or namespace name 'ResourceHarvestSuccessEventArgs
' could not be found (are you missing a using directive or an assembly reference
?)
+ KUSTOM/Achievement System/AchieveTypes/ItemCraftedAchievement.cs:
CS0246: Line 18: The type or namespace name 'CraftSuccessEventArgs' could no
t be found (are you missing a using directive or an assembly reference?)
 

Frosttiger

Citizen
runuo doesn't have them eventsinks. if you look at where the eventsinks are in the core and add them to you runuo core then the system should work but make sure you do them the way the event sinks are set up/

Well I'm glad people our willing to jump in and expand on these I think its a nice little drag and drop system that doesn't require veta nex or any other scripts.

if you call make new event sinks please share I was going to work on these my self but I have other projects that I think is more importin then a achievement system that makes uo like any other game., but hell if I find a fix or a bug ill try my bets to help out.
 

sahisahi

Rookie
runuo doesn't have them eventsinks. if you look at where the eventsinks are in the core and add them to you runuo core then the system should work but make sure you do them the way the event sinks are set up/

Well I'm glad people our willing to jump in and expand on these I think its a nice little drag and drop system that doesn't require veta nex or any other scripts.

if you call make new event sinks please share I was going to work on these my self but I have other projects that I think is more importin then a achievement system that makes uo like any other game., but hell if I find a fix or a bug ill try my bets to help out.

Im not good at scripting, i wish i could fix it for runuo
 

tass23

Moderator
I stand corrected. I was unaware this setup would require Core modifications (edits to Server files). My original Core was damaged years ago, so I can recompile mine, which means I could never install a system like this.

So, I guess my question is now:
Is it possible to make "core" edits without recompiling the core, i.e. could a system like this be installed by adding the EventSink in for each achievement, right in the Achievement Type script?
 

Tim

Citizen
The Script that is in question belongs to darklotus.
Here is a peace of the conversation we had :)

Also You want to delete the skills and and item crafted achievments he told me that something runuo has that servuo don't . Got to do with event sink.

darklotus said...
"Entire system is mostly just a proof of concept, since i saw so many people looking for a system like this and no one was sharing, so i figured a base to start from would help.
Im happy to accept fixes and additions on github from anyone for the system. Hopefully have time one day to flesh it out a bit more and add some more documentation."