Bank Check as Quest Item

[Iomega0318]

ServUO Version

Publish 57

Ultima Expansion

Endless Journey

How can I accept a bank check for a certain amount as a quest item turn in?
Adding it as the following does not seem to work as it's looking for an amount rather than the item if that makes sense..

AddObjective(new ObtainObjective(typeof(BankCheck), "Building Fund", 500000));

 

[Iomega0318]

Just bumping my thread, I still haven't been able to figure this one out.

 

[Voxpire]

You can create a new class that inherits from ObtainObjective, and override IsObjective(Item item) to determine whether the item passes the criteria:

public override bool IsObjective(Item item)
{
    if (!base.IsObjective(item))
        return false;

    if (item is BankCheck check && check.Worth == MaxProgress)
        return true;

    return false;
}

Ex. BankCheckObjective : ObtainObjective

 

[Iomega0318]

Probably doing something wrong I'm sure.. but

error CS0115: 'SecondHouseQuest.IsObjective(Item)': no suitable method found to override [C:\ServUO\Scripts\Scripts.csproj]

 

[Voxpire]

You can create a new class that inherits from ObtainObjective, and override IsObjective(Item item) to determine whether the item passes the criteria:

Ex. BankCheckObjective : ObtainObjective

The IsObjective method would be overridden in your new BankCheckObjective class, not the quest class itself.
When you add your objective to the quest, you would do 'new BankCheckObjective(...)` instead of 'new ObtainObjective(...)'

 

[Iomega0318]

The IsObjective method would be overridden in your new BankCheckObjective class, not the quest class itself.
When you add your objective to the quest, you would do 'new BankCheckObjective(...)` instead of 'new ObtainObjective(...)'

So I would be adding this?

AddObjective(new BankCheckObjective(typeof(BankCheck), "Building Fund", 500000));

 

[Voxpire]

Yes, but you need to code the BankCheckObjective so that you can use it.

This is pretty much the only existing example of a system that creates a custom ObtainObjective in a simple enough way to get started as a reference

ServUO/ElfHeritage.cs at master · ServUO/ServUO

An Ultima Online server emulator written in C# .NET - ServUO/ElfHeritage.cs at master · ServUO/ServUO

github.com

 

[Iomega0318]

Oh boy.. where's the mind explosion smiley when you need one lol.. I'll take a look haha

 

[Iomega0318]

So something like this I assume? It compiles but I can't turn in the quest..

        private class InternalObjective : ObtainObjective
        {
            public InternalObjective()
                : base(typeof(BankCheck), "Building Fund", 500000)
            {
            }

            public override bool IsObjective(Item item)
            {
                if (base.IsObjective(item))
                {
                    if (item is BankCheck check && check.Worth == MaxProgress)
                        return true;
                }

                return false;
            }

            public override void Serialize(GenericWriter writer)
            {
                base.Serialize(writer);

                writer.WriteEncodedInt(0); // version
            }

            public override void Deserialize(GenericReader reader)
            {
                base.Deserialize(reader);

                int version = reader.ReadEncodedInt();
            }
        }

        public SecondHouseQuest() : base()
        {
            AddObjective(new ObtainObjective(typeof(IronIngot), "Nails", 1000));
            AddObjective(new ObtainObjective(typeof(Log), "Lumber", 350));
            AddObjective(new ObtainObjective(typeof(BankCheck), "Building Fund", 500000));
            AddReward(new BaseReward(typeof(ExtraHouseDeed), "+1 Extra House"));
        }

 

[Voxpire]

Do you need to mark the check as a quest item via the context menu before you can turn it in?

 

[Iomega0318]

Do you need to mark the check as a quest item via the context menu before you can turn it in?

I did mark it yes, but unless I make the check "amount" 500000 I can't turn it in. I assume it's still thinking there should be a "stack" of items.

 

[Voxpire]

Try this

        private class InternalObjective : ObtainObjective
        {
            public InternalObjective()
                : base(typeof(BankCheck), "Building Fund", 1)
            {
            }

            public override bool IsObjective(Item item)
            {
                if (base.IsObjective(item))
                {
                    if (item is BankCheck check && check.Worth == 500000)
                        return true;
                }

                return false;
            }

            public override void Serialize(GenericWriter writer)
            {
                base.Serialize(writer);

                writer.WriteEncodedInt(0); // version
            }

            public override void Deserialize(GenericReader reader)
            {
                base.Deserialize(reader);

                int version = reader.ReadEncodedInt();
            }
        }

        public SecondHouseQuest() : base()
        {
            AddObjective(new ObtainObjective(typeof(IronIngot), "Nails", 1000));
            AddObjective(new ObtainObjective(typeof(Log), "Lumber", 350));
            AddObjective(new ObtainObjective(typeof(BankCheck), "Building Fund", 500000));
            AddReward(new BaseReward(typeof(ExtraHouseDeed), "+1 Extra House"));
        }

 

[Iomega0318]

Hmm nope still wants it to be a stack of items haha..

 

[Voxpire]

My bad, I missed that part at the bottom

        public SecondHouseQuest() : base()
        {
            AddObjective(new ObtainObjective(typeof(IronIngot), "Nails", 1000));
            AddObjective(new ObtainObjective(typeof(Log), "Lumber", 350));
            AddObjective(new InternalObjective()); // Building Fund

            AddReward(new BaseReward(typeof(ExtraHouseDeed), "+1 Extra House"));
        }

 

[Iomega0318]

Looks like that did the trick! Seems to be working as expected haha, thank you!