Alright I added something to this that should help:
TimeSpan delay = TimeSpan.FromSeconds(Utility.RandomMinMax(0.5, 4));
Timer = new AbilityCooldownTimer(this, delay);It works perfectly! Thank you so much from the bottom of my heart!
Awesome! That's good to know.
Hey again, Bala, I appreciate your comments!
else if (Active == true && Owner.Controlled && m is BaseCreature )else if (Active == true && Owner.Controlled && m is BaseCreature && m != Owner)Map map = m_Item.Map;
BaseCreature owner = m_Item.Owner; Mobile master = null;
if (owner.Controlled)
master = owner.ControlMaster; if (owner != null && !owner.Deleted)
{
if (master != null && !master.Deleted)
{
foreach (Mobile m in eable)
{
if (m != master && m != owner && !owner.IsFriend(m) && (m.Z + 16) > m_Item.Z && (m_Item.Z + 12) > m.Z )
m_Queue.Enqueue(m);
}
}
else
{
foreach (Mobile m in eable)
{
if (m != owner && !owner.IsFriend(m) && (m.Z + 16) > m_Item.Z && (m_Item.Z + 12) > m.Z )
m_Queue.Enqueue(m);
}
}
}
else
{
foreach (Mobile m in eable)
{
if ((m.Z + 16) > m_Item.Z && (m_Item.Z + 12) > m.Z )
m_Queue.Enqueue(m);
}
}
eable.Free(); private int m_Damage; private BaseCreature m_Owner;
[CommandProperty(AccessLevel.GameMaster)]
public BaseCreature Owner
{
get { return m_Owner; }
set { m_Owner = value; }
} public override bool OnMoveOver(Mobile m)
{
if(Owner != null && !Owner.Deleted)
{
if (!Owner.Controlled && Active == true && (m is PlayerMobile || (m is BaseCreature && ((BaseCreature)m).GetMaster() is PlayerMobile)))
{
int damage = m_Damage;
if (!Core.AOS && m.CheckSkill(SkillName.MagicResist, 0.0, 30.0))
{
damage = 1;
m.SendLocalizedMessage(501783); // You feel yourself resisting magical energy.
}
AOS.Damage(m, damage, 0, 100, 0, 0, 0);
m.PlaySound(0x22A);
}
else if (Active == true && Owner.Controlled && m is BaseCreature && m != Owner)
{
int damage = m_Damage;
if (!Core.AOS && m.CheckSkill(SkillName.MagicResist, 0.0, 30.0))
{
damage = 1;
m.SendLocalizedMessage(501783); // You feel yourself resisting magical energy.
}
AOS.Damage(m, damage, 0, 100, 0, 0, 0);
m.PlaySound(0x208);
}
}
else if (Active == true )
{
int damage = m_Damage/2;
if (!Core.AOS && m.CheckSkill(SkillName.MagicResist, 0.0, 30.0))
{
damage = 1;
m.SendLocalizedMessage(501783); // You feel yourself resisting magical energy.
}
AOS.Damage(m, damage, 0, 100, 0, 0, 0);
m.PlaySound(0x208);
}
return true;
} BaseCreature owner = m_Item.Owner;
if (owner.Controlled)
master = owner.ControlMaster; IPooledEnumerable eable = m_Item.GetMobilesInRange(0);
if (owner != null && !owner.Deleted)
{
if (master != null && !master.Deleted)
{
foreach (Mobile m in eable)
{
if (m != master && m != owner && !owner.IsFriend(m) && (m.Z + 16) > m_Item.Z && (m_Item.Z + 12) > m.Z )
m_Queue.Enqueue(m);
}
}
else
{
foreach (Mobile m in eable)
{
if (m != owner && !owner.IsFriend(m) && (m.Z + 16) > m_Item.Z && (m_Item.Z + 12) > m.Z )
m_Queue.Enqueue(m);
}
}
}
else
{
foreach (Mobile m in eable)
{
if ((m.Z + 16) > m_Item.Z && (m_Item.Z + 12) > m.Z )
m_Queue.Enqueue(m);
}
}
eable.Free();m_Item.Owner = creature;looks like FireItem.cs is missing this piece:
BaseCreature owner = m_Item.Owner;
Mobile master = null;
if (owner.Controlled)
master = owner.ControlMaster;I've solved the problem perfectly. Thank you! And I'm so sorry. I just want to ask for one more help. While studying about the server, I happened to see a video of a server called Outland. Like the gif photo I posted, fire elemental monsters try their magic and then fireball in large numbers where they are designated. And there is a spark where it is launched and all the monsters within that range do the damage of the number of fireballs. I wanted to change it by applying the BarrageOfBolts magic from the ability you raised, but I think it's an area that I can't reach. Can you please share your knowledge of what modifications to go through to create a magic similar to the picture?
Yeah, Outlands is great! They've done amazing work with UO.
using System;
using Server;using System.Collections.Generic;
using System.Linq;
using Server.Items;
using Server.Network;
using System.Collections;
using Server.Spells;
namespace Server.Mobiles
{
public class VolleyOfBolts : CustomAbility
{
public override int MaxRange{ get { return 12; } }
public override double TriggerChance { get { return 1.0; } }
public override TimeSpan CooldownDuration { get { return TimeSpan.FromSeconds(15); } }
private static Hashtable Table = new Hashtable();
private int m_ItemID;
private int m_Hue;
private int m_SoundID;
private int m_Min;
private int m_Max;
public int ItemID
{
get { return m_ItemID; }
set { m_ItemID = value; }
}
public int Hue
{
get { return m_Hue; }
set { m_Hue = value; }
}
public int Sound
{
get { return m_SoundID; }
set { m_SoundID = value; }
}
public VolleyOfBolts()
{
m_ItemID = 0x36D4;
m_Hue = 0;
m_SoundID = 0x349;
m_Min = 12;
m_Max = 18;
}
public void SetDamage(int min, int max)
{
m_Min = min;
m_Max = max;
}
public override void Trigger(BaseCreature creature, Mobile defender, int min, int max)
{
if(min == 0 && max == 0)
{
min = m_Min;
max = m_Max;
}
if(creature.InRange(defender.Location, MaxRange) && TriggerChance >= Utility.RandomDouble() && !IsInCooldown(creature))
{
DoEffects(creature, defender, min, max);
AddToCooldown(creature);
}
}
public override void DoEffects(BaseCreature creature, Mobile defender, int min, int max)
{
if (defender == null || defender.Deleted || !defender.Alive || !creature.Alive || !creature.CanBeHarmful(defender))
return;
if( creature.Body == 0x191 || creature.Body == 0x190)
creature.Animate(AnimationType.Spell, 0);
Timer t = new BoltTimer(creature, defender, this, min, max);
t.Start();
Table[defender] = t;
}
public void DoVolley(BaseCreature creature, Point3D p, int min, int max)
{
Point3D random = new Point3D(p.X + Utility.RandomMinMax(-1, 1), p.Y + Utility.RandomMinMax(-1, 1), p.Z);
TargetLocationItem r_Item = new TargetLocationItem();
r_Item.MoveToWorld(random, creature.Map);
//Effects.PlaySound(p.Location, p.Map, m_SoundID);
Effects.PlaySound(creature.Location, creature.Map, m_SoundID);
creature.MovingEffect(r_Item, m_ItemID, 1, 0, false, false, m_Hue, 0);
IPooledEnumerable eable = r_Item.GetMobilesInRange(1);
foreach (Mobile m in eable)
{
Timer.DelayCall(TimeSpan.FromSeconds(creature.GetDistanceToSqrt(r_Item) / 5.0), () =>
{
if (creature.Controlled && m is BaseCreature && !((BaseCreature)m).Controlled)
{
int d = Utility.RandomMinMax(min, max);
AOS.Damage(m, d, 100, 0, 0, 0, 0);
}
else if (!creature.Controlled && ((m is PlayerMobile || (m is BaseCreature && ((BaseCreature)m).GetMaster() is PlayerMobile))))
{
int d = Utility.RandomMinMax(min, max);
AOS.Damage(m, d, 100, 0, 0, 0, 0);
}
});
}
eable.Free();
}
public static void EndEffect(Mobile m, bool message)
{
Timer t = (Timer)Table[m];
if (t != null)
{
t.Stop();
Table.Remove(m);
}
}
public override void Serialize(GenericWriter writer)
{
writer.Write(m_Min);
writer.Write(m_Max);
}
public override void Deserialize(GenericReader reader)
{
m_Min = reader.ReadInt();
m_Max = reader.ReadInt();
}
private class BoltTimer : Timer
{
private BaseCreature Creature;
private Mobile Defender;
private VolleyOfBolts Ability;
private int Min;
private int Max;
private DateTime NextBolt;
private DateTime Expire;
public BoltTimer(BaseCreature creature, Mobile defender, VolleyOfBolts vob, int min, int max)
: base(TimeSpan.FromSeconds(0.1), TimeSpan.FromSeconds(0.1))
{
Creature = creature;
Defender = defender;
Ability = vob;
Min = min;
Max = max;
Priority = TimerPriority.TwoFiftyMS;
creature.Frozen = true;
Expire = DateTime.UtcNow + TimeSpan.FromSeconds(3);
NextBolt = DateTime.UtcNow + TimeSpan.FromSeconds(0.5);
}
protected override void OnTick()
{
if (!Defender.Alive || Defender.Deleted)
{
EndEffect(Defender, true);
}
else if (DateTime.UtcNow < NextBolt)
{
return;
}
else if (DateTime.UtcNow >= NextBolt)
{
Ability.DoVolley(Creature, Defender.Location, Min, Max);
}
if (DateTime.UtcNow >= Expire)
{
Creature.Frozen = false;
EndEffect(Defender, true);
}
}
}
}
} _Abilities = new CustomAbility[31]; _Abilities[29] = new Snare(); _Abilities[30] = new VolleyOfBolts(); public static CustomAbility Snare
{
get
{
return _Abilities[29];
}
} public static CustomAbility VolleyOfBolts
{
get
{
return _Abilities[30];
}
}Outland is great, but to me, you're an even greater person. It works perfectly and it's the best! While using these abilities, I got a question. Can I find out why when a tame monster uses these abilities, such as a newly created magic and acidpool item, it doesn't show damage when attacking an opponent? Damage is applied without a problem, but no attack damage is shown.
Well, I've got another problem as I keep experimenting. When the tame monster uses the VolleyOfBolts ability, there is no damage in the player-to-player battle. I'm sorry for asking too much..
Thank you! And yes I think I can help you with that.
AOS.Damage(m, m_Owner, damage, 0, 100, 0, 0, 0);AOS.Damage(m, m_Owner, damage, 0, 0, 0, 100, 0);sure!
if (creature.Controlled && m is BaseCreature && !((BaseCreature)m).Controlled)
{
int d = Utility.RandomMinMax(min, max);
AOS.Damage(m, d, 100, 0, 0, 0, 0);
} if (creature.Controlled && (m is BaseCreature && !((BaseCreature)m).Controlled) || m is PlayerMobile && m != ((BaseCreature)m).ControlMaster )
{
int d = Utility.RandomMinMax(min, max);
AOS.Damage(m, d, 100, 0, 0, 0, 0);
}I really appreciate your help, but I get the following and above errors.
And the server will reboot when the monster attempts to place an order for the ValleyOfBolts to another player or yourself. Below is the crash log.
And can you please share the knowledge of what I need to add to show damage even when tame monsters use ValleyOfBolts orders?
Alright, I think I got the fixes for both of your issues.
BaseCreature owner = m_Item.Owner;AOS.Damage(m, owner, damage, 0, 100, 0, 0, 0); if (creature.Controlled && (m is BaseCreature && !((BaseCreature)m).Controlled) || m is PlayerMobile && m != ((BaseCreature)creature).ControlMaster)AOS.Damage(m, creature, d, 100, 0, 0, 0, 0);Cheers!! It works perfectly! It may be boring to say the same thing all the time, but you are really the best and awesome. I have some free time, so I did a little more testing and found a few more problems. Sorry to bother you.. When a tame monster attempts a ToxicRain and ImpaleAoe order, the tame monster gets damaged together when the script part above is working. And ImpaleAoe with this ability, it seems that the bleeding disorder is not working properly. Thank you for always taking your time to me..
I'm gonna look into toxic rain and impale aoe later today or tomorrow, but for the valley of bolts ability, you want the fireballs to remain in the starting area instead of following the target around, right?
It doesn't matter if it takes a long time. I can wait with appreciation, no matter how long it takes. The VolleyOfBolts ability I wanted allows monsters to demonstrate the VolleyOfBolts ability and fly extensive fireballs in the location where the target stood. Even if the target suddenly disappears while using the ability, the fireball still spills out in the location you set once. If you think that the MeteorShower ability is attacking by pouring fireballs into a range similar to the picture above, I think you'll probably get a similar result. I'm sorry for not being able to convey my thoughts in detail because of the limitations of the translation. And I'm always making up the server feeling grateful to you. Thank you so much from the bottom of my heart.
Okay, so for the volley of bolts ability, you just have to add a few changes to the Timer.
private class BoltTimer : Timer private Point3D Loc; Creature = creature;
Defender = defender;
Ability = vob;
Min = min;
Max = max; Loc = defender.Location; Ability.DoVolley(Creature, Defender.Location, Min, Max); Ability.DoVolley(Creature, Loc, Min, Max);Timer.DelayCall(TimeSpan.FromSeconds(creature.GetDistanceToSqrt(r_Item) / 5.0),if (m.Alive && !m.IsDeadBondedPet)if (m.Alive && !m.IsDeadBondedPet && (m != from))I just finished testing. It works exactly as I wanted it to. Thank you so much for helping me with the incredible knowledge and abilities you have. I know it's boring because I'm saying it every time, but I just want to say it again. To me, you are truly respectful and the most wonderful person.
using System;
using Server;using System.Collections.Generic;
using System.Linq;
using Server.Items;
using Server.Network;
using System.Collections;
using Server.Spells;
namespace Server.Mobiles
{
public class ImpaleAoe : CustomAbility
{
public override double TriggerChance { get { return 0.2; } }
public override int MaxRange { get { return 5; } }
public override TimeSpan CooldownDuration { get { return TimeSpan.FromSeconds(25); } }
private static readonly Dictionary<Mobile, BleedTimer> m_BleedTable = new Dictionary<Mobile, BleedTimer>();
public static bool IsBleeding(Mobile m)
{
return m_BleedTable.ContainsKey(m);
}
private int m_ItemID;
private int m_Hue;
private int m_Min;
private int m_Max;
public int ItemID
{
get { return m_ItemID; }
set { m_ItemID = value; }
}
public int Hue
{
get { return m_Hue; }
set { m_Hue = value; }
}
public ImpaleAoe()
{
m_ItemID = Utility.RandomList(0x8E0, 0x8E7, 0x8E1);
m_Hue = 0;
m_Min = 11;
m_Max = 29;
}
public void SetDamage(int min, int max)
{
m_Min = min;
m_Max = max;
}
public int GetDamage()
{
return Utility.RandomMinMax(m_Min, m_Max);
}
public override void Trigger(BaseCreature creature, Mobile defender, int min, int max)
{
if(min == 0 && max == 0)
{
min = m_Min;
max = m_Max;
}
if(creature.InRange(defender.Location, MaxRange) && TriggerChance >= Utility.RandomDouble() && !IsInCooldown(creature))
{
DoEffects(creature, defender, min, max);
AddToCooldown(creature);
}
}
public override void DoEffects(BaseCreature creature, Mobile defender, int min, int max)
{
if( creature.Body == 0x191 || creature.Body == 0x190)
creature.Animate(AnimationType.Spell, 0);
else
creature.Animate(AnimationType.Attack, 0);
if (!creature.Alive || creature.Map == null)
return;
BeginBleed(defender, creature, this);
}
public static void BeginBleed(Mobile defender, Mobile creature, ImpaleAoe ability)
{
BeginBleed(defender, creature, ability, false);
}
public static void BeginBleed(Mobile defender, Mobile creature, ImpaleAoe ability, bool splintering)
{
BleedTimer timer = null;
Effects.PlaySound(defender.Location, defender.Map, 0x21D);
BaseCreature bc = creature as BaseCreature;
IPooledEnumerable eable = creature.GetMobilesInRange(ability.MaxRange);
foreach (Mobile m in eable)
{
if (!bc.Controlled && (m is PlayerMobile || (m is BaseCreature && ((BaseCreature)m).GetMaster() is PlayerMobile)) && creature.CanBeHarmful(m)
|| bc.Controlled && (m is BaseCreature && !((BaseCreature)m).Controlled))
{
if (m_BleedTable.ContainsKey(m))
{
if (splintering)
{
timer = m_BleedTable[m];
timer.Stop();
}
else
{
return;
}
}
Effects.SendLocationEffect(EffectItem.Create(m.Location, m.Map, EffectItem.DefaultDuration), m.Map, ability.ItemID, 150, 10, ability.Hue, 0); //0xAA8 is ice
Timer.DelayCall(TimeSpan.FromSeconds(0.75), () =>
{
int d = ability.GetDamage();
AOS.Damage(m, creature, d, 100, 0, 0, 0, 0);
timer = new BleedTimer(creature, m);
m_BleedTable[m] = timer;
timer.Start();
m.SendLocalizedMessage(1060160); // You are bleeding!
if (m is PlayerMobile)
{
m.LocalOverheadMessage(MessageType.Regular, 0x21, 1060757); // You are bleeding profusely
m.NonlocalOverheadMessage(MessageType.Regular, 0x21, 1060758, m.Name); // ~1_NAME~ is bleeding profusely
}
m.FixedParticles(0x377A, 244, 25, 9950, 31, 0, EffectLayer.Waist);
});
}
}
eable.Free();
}
public static void DoBleed(Mobile m, Mobile from, int damage)
{
if (m.Alive && !m.IsDeadBondedPet && m != from)
{
if (!m.Player)
damage *= 2;
m.PlaySound(0x133);
AOS.Damage(m, from, damage, false, 0, 0, 0, 0, 0, 0, 100, false, false, false);
Blood blood = new Blood();
blood.ItemID = Utility.Random(0x122A, 5);
blood.MoveToWorld(m.Location, m.Map);
}
else
{
EndBleed(m, false);
}
}
public static void EndBleed(Mobile m, bool message)
{
Timer t = null;
if (m_BleedTable.ContainsKey(m))
{
t = m_BleedTable[m];
m_BleedTable.Remove(m);
}
if (t == null)
return;
t.Stop();
if (message)
m.SendLocalizedMessage(1060167); // The bleeding wounds have healed, you are no longer bleeding!
}
private class BleedTimer : Timer
{
private readonly Mobile m_From;
private readonly Mobile m_Mobile;
private int m_Count;
private int m_MaxCount;
public BleedTimer(Mobile from, Mobile m)
: base(TimeSpan.FromSeconds(2.0), TimeSpan.FromSeconds(2.0))
{
m_From = from;
m_Mobile = m;
Priority = TimerPriority.TwoFiftyMS;
m_MaxCount = 5;
}
protected override void OnTick()
{
if (!m_Mobile.Alive || m_Mobile.Deleted )
{
EndBleed(m_Mobile, true);
}
else
{
int damage = 0;
if (!Server.Spells.SkillMasteries.WhiteTigerFormSpell.HasBleedMod(m_From, out damage))
damage = Math.Max(1, Utility.RandomMinMax(5 - m_Count, (5 - m_Count) * 2));
DoBleed(m_Mobile, m_From, damage);
if (++m_Count == m_MaxCount)
EndBleed(m_Mobile, true);
}
}
}
public override void Serialize(GenericWriter writer)
{
writer.Write(m_ItemID);
writer.Write(m_Hue);
writer.Write(m_Min);
writer.Write(m_Max);
}
public override void Deserialize(GenericReader reader)
{
m_ItemID = reader.ReadInt();
m_Hue = reader.ReadInt();
m_Min = reader.ReadInt();
m_Max = reader.ReadInt();
}
}
}
Thank you so much for always responding so kindly. I found two more problems with the VolleyOfBolts. I think this is probably really the last problem. As shown in the pictures above, when the subpoena monster uses the VolleyOfBolts ability for other monsters, an innocent player nearby takes damage together. It's the same when you form a party and try it. And when the subpoenaed monsters used their ability, it didn't cause any damage as well. I tried to solve it using my knowledge as much as I could because I think I need to fix it in the script above, but I couldn't get the correct answer. I wonder if it's possible to fix it so that damage can be done to criminals, not innocent players. And I'm also curious about why the subpoenaed monsters don't have damage. I'm sorry I'm too greedy..
if (!creature.Controlled && (m is PlayerMobile || (m is BaseCreature && ((BaseCreature)m).GetMaster() is PlayerMobile)) && creature.CanBeHarmful(m))
{
//creature is wild, m is player or pet of player
int d = Utility.RandomMinMax(min, max);
AOS.Damage(m, creature, d, 100, 0, 0, 0, 0);
}
else if (creature.Controlled && (m is BaseCreature && !((BaseCreature)m).Controlled && m.Karma < 0) || (m.Criminal || m.Murderer))
{
//creature is tamed, m is not a tamed pet and m's karma is less than 0, or m is a criminal or murderer (players)
int d = Utility.RandomMinMax(min, max);
AOS.Damage(m, creature, d, 100, 0, 0, 0, 0);
}
else if (creature.Controlled && (m is BaseCreature && ((BaseCreature)m).Controlled && (((BaseCreature)m).ControlMaster.Criminal || ((BaseCreature)m).ControlMaster.Murderer)))
{
// creature is tamed, m is pet of criminal or murderer
int d = Utility.RandomMinMax(min, max);
AOS.Damage(m, creature, d, 100, 0, 0, 0, 0);
}It's a disadvantage that I can overcome and solve enough. I really appreciate your help for a long time. I'm truly happy. I always bless you.
Oh, my God. One fatal error has occurred. If you apply the new script you told me, create a monster that gives the VolleyOfBolts ability on the map, save it, and run the server, you will get a message to delete the monster as follows. I tested if other abilities were experiencing the same problem, but it didn't. The existing VolleyOfBolts script didn't have a problem, but I think it's happening in the script you told me at the end.
That's strange. What else did you add to the script around that time?
public override void Serialize(GenericWriter writer)
{
writer.Write(m_Min);
writer.Write(m_Max);
}
public override void Deserialize(GenericReader reader)
{
m_Min = reader.ReadInt();
m_Max = reader.ReadInt();
}I didn't touch what you said at all. The script above is what I'm currently applying and using. I'm not sure what I did wrong..
I can't find anything in your code that would cause that issue.
if ((m is PlayerMobile || (m is BaseCreature && ((BaseCreature)m).GetMaster() is PlayerMobile)) && creature.CanBeHarmful(m))
{
//// damage goes here ////
}Seriously, I was stupid. I made a very simple mistake. I made a mistake not to add the VolleyOfBolts ability to the CustomAbility.cs script. I solved it perfectly. I'm so sorry. I'm so, so, so, so stupid. I'm sorry to take your precious time away from my stupidity. And thank you so much from the bottom of my heart.
Ohhh! Yup, that'll do it lol. No worries, mistakes like this happen all the time. I'm glad we could figure it out though.
Thank you so much! Cheers!!
Oh my god.. I found a new problem using the VolleyOfBolts capability. If there are multiple monsters using the VolleyOfBolts capability as shown in the picture above, the capability will continue to be used until the opponent dies or is deleted. Both the monsters you summoned and the monsters you created in the field work the same. I post the scrip I'm using together. Can someone help me with what I did wrong?
Oh man, that's not good lol.
if (!Defender.Alive || Defender.Deleted || DateTime.UtcNow >= Expire)
{
Creature.Frozen = false;
EndEffect(Defender, true);
}Perfectly solved! You are the best who always offer solutions. Thank you always!