1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Engraved Text on BaseWeapon - what do notes mean?

Discussion in 'Script Support' started by Lokai, Mar 20, 2017.

  1. Lokai
    Offline

    Moderator ServUO Developer

    Joined:
    Dec 4, 2014
    Messages:
    879
    Likes Received:
    135
    Found this in BaseWeapon.cs:

    Code (C#):
    1.  
    2.  
    3.             /*
    4.             * Want to move this to the engraving tool, let the non-harmful
    5.             * formatting show, and remove CLILOCs embedded: more like OSI
    6.             * did with the books that had markup, etc.
    7.             *
    8.             * This will have a negative effect on a few event things imgame
    9.             * as is.
    10.             *
    11.             * If we cant find a more OSI-ish way to clean it up, we can
    12.             * easily put this back, and use it in the deserialize
    13.             * method and engraving tool, to make it perm cleaned up.
    14.             */
    15.  
    16.             if (!String.IsNullOrEmpty(m_EngravedText))
    17.             {
    18.                 list.Add(1062613, m_EngravedText);
    19.             }
    20.             /* list.Add( 1062613, Utility.FixHtml( m_EngravedText ) ); */
    I was thinking of doing something similar in BaseArmor, but I am not sure what these notes are about. Does anyone know what they mean?

    What is the "negative effect"?


    ** EDIT **

    I am using the latest ServUO, but just noticed that this has been around since RunUO 2.2 - 2.3 ish. Evidently these notes have survived many versions of the Server. Perhaps only a true old-timer would be able to answer this...
     
    #1 Lokai, Mar 20, 2017
    Last edited: Mar 20, 2017
  2. Talow
    Offline

    Talow Active Member

    Joined:
    Aug 30, 2014
    Messages:
    293
    Likes Received:
    28
    Based on what I see the field is able to display the limited html that the UO client is able to support. So when engraving <Color=####> would have an effect. The Clean up that's now commented out he was saying could be handled during server load and would be cleaned up at that time... Moving it to the Engraving tool would mean the clean up would be done when getting the text from the user.
     
    • Thanks! Thanks! x 1
  3. Lokai
    Offline

    Moderator ServUO Developer

    Joined:
    Dec 4, 2014
    Messages:
    879
    Likes Received:
    135
    Thank you. That helps clarify what they are saying. It would be nice to add the similar code into BaseArmor sometime. I have created the engraving tool, but it needs that part in there to be fully working.
     
  4. Hammerhand
    Offline

    Hammerhand Active Member

    Joined:
    Mar 26, 2013
    Messages:
    778
    Likes Received:
    74
    A server I staffed on & scripted for some years back had engravable armor. We used
    Code (C#):
    1.             list.Add(1053099, "{0}\t{1}", oreType, GetNameString()); // ~1_oretype~ ~2_armortype~
    2.             if (!String.IsNullOrEmpty(m_EngravedText))
    3.                 list.Add(1062613, m_EngravedText);
    at the bottom of the AddNameProperty.
    As I recall, we had some odd names on armor, weapons & containers for a while.
     
Similar Threads: Engraved Text
Forum Title Date
Script Support BulletinBoard and PlayerProfile text hues on dark Apr 1, 2017
Script Support Translating Context menu? Feb 16, 2017
Archived Bug Reports Need to remove "Cancel renewing inventory insurance" from context menu Jan 6, 2017
Archived Bug Reports VvV text display bug Jan 3, 2017
Script Support Same text string, 2 different hues? Oct 21, 2016
Script Support How to send text to the UO client from 3rd party software Oct 2, 2016
Script Support I'd tried to translate some text of servuo scripts and got problem,need help. Jul 5, 2016