1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Expansion flag not setting correctly

Discussion in 'Script Support' started by Ravenwolfe, Jan 16, 2014.

  1. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    When you use ServUO to create an oldschool shard, it is not correctly flagging something with Gargoyles.

    This is tested with the latest client and the Expansion Flag set to UOR. It is correctly blocking the creation of an elf with the message that the server does not support it (see below).

    cc2.jpg
    However, it is not correctly blocking the creation of a gargoyle (see below) It lets them create the gargoyle and then converts them to human on character creation (this is correctly done in the CharacterCreation.cs). It should block them from creating it at all just like it does the elf.

    cc3.jpg

    My thought is there is something wrong with the Expansion flag? I've been looking but thus far have not found the answer. Any ideas?
     
    #1 Ravenwolfe, Jan 16, 2014
    Last edited: Jan 16, 2014
  2. Kalamus
    Offline

    Kalamus Active Member

    Joined:
    Apr 24, 2013
    Messages:
    282
    Likes Received:
    32
    I can't seem to reproduce this on a fresh ServUO install. I tried setting the Expansion to None as well as a couple others. Anything set below SA and I can't even click the Gargoyle button to select the Gargoyle race. I tried with both the latest client (7.0.34.6) as well as an older client (7.0.15.1). :confused:
     
    • Like Like x 1
  3. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    @Kalamus Interesting, I have not changed much from the distro yet.

    I actually have my expansion set to UOR not NONE. Would you do me a huge favor and try the same thing with it set on UOR?

    I did notice that Marks shard Zenvera has the same issue and Im pretty sure he uses RunUO not ServUO.
     
  4. Kalamus
    Offline

    Kalamus Active Member

    Joined:
    Apr 24, 2013
    Messages:
    282
    Likes Received:
    32
    Just tried UOR and I still can't select the Gargoyle as a race on the create character screen. Just for kicks I just tried with my RunUO 2.5 (github) and my RunUO 2.3 (svn) at UOR and still the same result. These should be all clean distros for me so I'm not sure what edit you would have that's not blocking it for you.
     
  5. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    Wow, that is so weird. I have a list of everything that I have edited, so I will go thru it. I'm also going to try a fresh server.

    Curious, are you using Razor or UOSteam. I tried both, but I'm trying to think of anything that could be doing this!

    I appreciate your help!
     
  6. Kalamus
    Offline

    Kalamus Active Member

    Joined:
    Apr 24, 2013
    Messages:
    282
    Likes Received:
    32
    I'm using UOSteam. I guess I should clarify too that it's not blocking the same way the Elf does by not letting you click arrow in the bottom right. It's totally blocking the Gargoyle selection period. I can see the Gargoyle button but clicking it does nothing at all. Won't even show me the preview of the Gargoyle with any expansion setting below SA.
     
    • Agree Agree x 1
  7. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    OMFG! I'm such an idiot! I looked at my changelog and immediately see the problem!!

    I added this script which is supposed to allow you to use the newer art on an older expansion setting, but its clearly what is causing the problem!
    Code (C#):
    1. using System;
    2. using Server;
    3. using Server.Network;
    4.  
    5. namespace Server.Misc
    6. {
    7.     public class ExpansionArt
    8.     {
    9.           public static void Initialize() {
    10.           Server.Network.SupportedFeatures.Value = FeatureFlags.ExpansionSA;
    11.  
    12.         }
    13.     }
    14. }
    I don't guess there is another way to have the art but not the gargoyle option huh?
     
  8. Kalamus
    Offline

    Kalamus Active Member

    Joined:
    Apr 24, 2013
    Messages:
    282
    Likes Received:
    32
    Hmm haven't messed with art on lower Expansion settings. I could totally be off base here but I didn't think the Expansion settings messed with what art is available. I would have to dig into the code to find that out for sure though.
     
  9. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    Well, I had noticed when I set the Expansion lower, the art was impacted. As an example, the ancient wyrm still used the old dragon art, even though in the ancient wyrm script it had the newer body value. So I did some research on RunUO forums and thats when I found that script listed as a solution. Of course, on RunUO they wouldn't have come across the issue with gargoyles, so they probably wouldn't notice.

    @Milva - so this is definitely not a bug, do we have a blockhead area this can be filed in? ;)
     
    • Agree Agree x 1
  10. Kalamus
    Offline

    Kalamus Active Member

    Joined:
    Apr 24, 2013
    Messages:
    282
    Likes Received:
    32
    Yeah seems you are right. Just tried the ancient wyrm and got the old graphic using T2A expansion. Weird though that not all of the graphics are limited because my Boura mount is fine and that's not T2A.
     
    • Two Thumbs Up Two Thumbs Up x 1
  11. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    Seems to be partly controlled by the client files, found this quote from Vorspire:

    So, I think the same flag does both things. I'm gonna think on some workarounds. I really appreciate all your help in discovering my error (I blame lack of sleep and a 4 year old!).
     
    • Two Thumbs Up Two Thumbs Up x 1
  12. Kalamus
    Offline

    Kalamus Active Member

    Joined:
    Apr 24, 2013
    Messages:
    282
    Likes Received:
    32
    Yeah, hehe I'm already toying with it right now :)
     
  13. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    Well, you can give out a custom bodyconv.def to all players, but there has got to be a better way...

    Code (C#):
    1. # This file overloads the data loaded from the CD/HD cache system from a very              
    2. "# low level.  Given a object type, it will return the index in"              
    3. # anim2.mul/anim3.mul/etc the game should use instead of art from anim.mul              
    4. #              
    5. # 0 - 199 = MOnsters              
    6. # 200 - 399 = Animals              
    7. # 400 + = HUmans/Elves and Equipment              
    8. #              
    9. # The maximum value for an index is 2048.              
    10. #              
    11. # <Object> <LBR version (anim2)> <AoS version (anim3)> <AoW version (anim4)><Mondain version (anim5)>              
    12. #              
    13. 157    1    -1    -1    -1
    14. 173    2    -1    -1    -1
    15. 11    3    -1    -1    -1
    16. 19    3    -1    -1    -1
    17. 20    4    -1    -1    -1
    18.  
    19. # This was the original line for the giant spiders since LBR              
    20. #28    5    -1    -1    -1
    21. #This line reverts the spiders back to the original style              
    22. 28    -1    -1    -1    -1
    23.  
     
  14. Kalamus
    Offline

    Kalamus Active Member

    Joined:
    Apr 24, 2013
    Messages:
    282
    Likes Received:
    32
    Yeah too many numbers to look at in those files. Lack of sleep is affecting me too. Those files is probably the only way out because the same packet sent to remove the Gargoyles is the same packet telling the client which version of the graphics to use. You could always ignore the Gargoyle issue and let it default to human if they do create one though. Not sure what else the version packet might limit.

    Glad I was able to help with your issue though :)
     
  15. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,147
    Likes Received:
    123
    Well, I added that previous file back in, but changed it to this:

    Code (C#):
    1. using System;
    2. using Server;
    3. using Server.Network;
    4.  
    5. namespace Server.Misc
    6. {
    7.     public class ExpansionArt
    8.     {
    9.           public static void Initialize() {
    10.           Server.Network.SupportedFeatures.Value = FeatureFlags.ExpansionSE;
    11.  
    12.         }
    13.     }
    14. }
    It does not let you pick Gargoyle but the art is updated. However, I gotta do a lot of testing to see if it impacts other systems. One thing I notice so far is that it does add the object properties list, which is not era accurate, but is actually pretty handy, lol.

    I will let you know after more testing.
     
  16. Milva
    Offline

    Admin Moderator

    Joined:
    Mar 3, 2013
    Messages:
    3,544
    Likes Received:
    389
    Scripting is always a learning lesson :) I will send this to script support, should fit :)
    I found this thread very interesting!
     
  17. mtindell
    Offline

    mtindell New Member

    Joined:
    Apr 5, 2015
    Messages:
    7
    Likes Received:
    1
    @Ravenwolfe, have you found any issues or incompatibilities with this since? Am doing something similar and want to see if you are seeing any undesired SE features leak in with this setup.
     
    #17 mtindell, Apr 12, 2015
    Last edited by a moderator: Apr 12, 2015
Similar Threads: Expansion flag
Forum Title Date
ServUO Discussion Hello!!! Question regarding spawns and expansions May 27, 2017
Windows Support Expansions Not Enabled Mar 2, 2017
Art 465 Expansion set Jan 19, 2017
ServUO Discussion Spawners Based on Expansion Chosen Dec 29, 2016
ServUO Discussion Set Pub54 + last uo client to ML expansion? Oct 24, 2016
Custom Releases Thief Guild Expansion Sep 30, 2016
General Discussion T2a expansion Jul 14, 2016