1. This site uses cookies. By continuing to use this site, you are agreeing to our use of cookies. Learn More.

Update AlterItem 2014-02-23

Fix and Update

  1. Omni
    Offline

    Omni Member

    Joined:
    Dec 22, 2013
    Messages:
    165
    Likes Received:
    24
    Omni submitted a new resource:

    Update AlterItem - Fix and Update

    Read more about this resource...
     
    • Like Like x 2
    • Two Thumbs Up Two Thumbs Up x 1
  2. Milva
    Offline

    Admin Moderator

    Joined:
    Mar 3, 2013
    Messages:
    3,421
    Likes Received:
    385
    Great idea! :)
     
  3. Omni
    Offline

    Omni Member

    Joined:
    Dec 22, 2013
    Messages:
    165
    Likes Received:
    24
    I take no credit for this at all just noticed it wasn't working fully so made it work and easier to install the mods
     
  4. Ravenwolfe
    Offline

    Moderator ServUO Developer

    Joined:
    Sep 7, 2013
    Messages:
    1,102
    Likes Received:
    117
    Thanks, I keep getting distracted and forget to finish the fixes!
     
  5. Omni
    Offline

    Omni Member

    Joined:
    Dec 22, 2013
    Messages:
    165
    Likes Received:
    24
    I think with the exception of Alter Deeds this is now complete..
     
  6. RedBeard
    Offline

    RedBeard Active Member

    Joined:
    May 19, 2013
    Messages:
    365
    Likes Received:
    72
    Nice work, this is shaping up, however, the items that are altered still don't carry over their attributes to the new gargoyle item.
    I also believe this is to work on artifacts so the script should probably list artifacts (armor & weapons) previous to SA expansion
    with correct altered Items (once the attribute problem is resolved).
    Any items post SA expansion seems to contain a human version and a gargoyle version if intended.

    example:
    HeartOfLion would become a GargishPlateChest with the same attributes and carry the artifact name over as well.

    Without carrying over the attributes there isn't much point to this. The artifact name & rarity would be mainly to value the item & distinguish its origin otherwise it might say "Exceptionally crafted by John Doe".

    [Food 4 Thought]
    Should it carry over the item hue as well. Quite possibly it would also need to carry over stuff like Dyeable, ItokunoDyeable, Engraved Text
     
    #6 RedBeard, Feb 23, 2014
    Last edited: Feb 23, 2014
  7. Omni
    Offline

    Omni Member

    Joined:
    Dec 22, 2013
    Messages:
    165
    Likes Received:
    24
    You know when I was testing this I didn't even look at attributes.

    Was simply adding a item of each type and converting it to gargoyle using alteritem.

    Back to the drawing board I guess
     
  8. Crome969
    Offline

    Crome969 Member

    Joined:
    Jan 9, 2014
    Messages:
    195
    Likes Received:
    20
    I just would change the ItemID instead of Recreating the Item. Layer and Properties are same as before, so you could just recreate the ID ...
     
  9. Omni
    Offline

    Omni Member

    Joined:
    Dec 22, 2013
    Messages:
    165
    Likes Received:
    24
    I have used the advanceditemid deeds before but this is a OSI style system that i would like to create and be osi accurate as it completes another chapter being closer to EA :)
     
  10. Juzzver
    Offline

    Juzzver New Member

    Joined:
    Sep 17, 2013
    Messages:
    21
    Likes Received:
    0
    There not have CraftGump, only CraftGroupCol.cs. System don't work on last ServUO Publish.
     
  11. Toriad
    Offline

    Toriad Shard Owner

    Joined:
    Mar 4, 2013
    Messages:
    86
    Likes Received:
    35
    Is this the fix for Alter Item? If so we should put it in core!
     
  12. Crome969
    Offline

    Crome969 Member

    Joined:
    Jan 9, 2014
    Messages:
    195
    Likes Received:
    20

    It must be included via OnResponse for Buttons on Craftgump.If required, i can check wich Tools actual supporting Altering. Then its just a list to Compare. If Type is X it will be Y. Shouldnt be much a Problem.
     
  13. Juzzver
    Offline

    Juzzver New Member

    Joined:
    Sep 17, 2013
    Messages:
    21
    Likes Received:
    0
    CraftGump.cs ( ServUO Script from Repo ) - empty block for Alter Item
    case 9: // Alter Item (Gargoyle)
    {
    break;
    }

    Class has not Called.
     
  14. Juzzver
    Offline

    Juzzver New Member

    Joined:
    Sep 17, 2013
    Messages:
    21
    Likes Received:
    0
    I tested this system, she is very raw.
    Or not all the files downloaded, or it is actually very incompletely
     
  15. RedBeard
    Offline

    RedBeard Active Member

    Joined:
    May 19, 2013
    Messages:
    365
    Likes Received:
    72
    Aye this isn't 100% yet, still need to make properties transferable. At present it converts the item ids accurately. I'm also not sure if it reacts to all trade menus or
    by correct tool with matching skill requirement.
     
  16. Juzzver
    Offline

    Juzzver New Member

    Joined:
    Sep 17, 2013
    Messages:
    21
    Likes Received:
    0
    I'm sorry. Not immediately read your message above.
    I still do not know very well English, this did not read the text discussion. Decided to go directly to the script :)
    But still, the script started to work - in the archive lacking mention of Alter Item.

    CraftSystem.cs -> need to register: Alter Item
    CraftGump.cs -> need to added call AlterItem.BeginAction method

    The archive was not these scripts...
     
  17. Omni
    Offline

    Omni Member

    Joined:
    Dec 22, 2013
    Messages:
    165
    Likes Received:
    24
    Currently this only changes the item ids for example.

    You can convert a human/elf half apron so a gargoyle can wear. I'd say this part is 95% complete.

    It doesn't copy over any attributes that the item previously had example. If you tried to alter a tangle it would just convert it to a half apron.

    It also requires alter item deeds.

    I'm renowned for starting things and never finishing especially OSI crap as I don't like OSI or clone hehe
     
  18. Crome969
    Offline

    Crome969 Member

    Joined:
    Jan 9, 2014
    Messages:
    195
    Likes Received:
    20
    As i know from EA ( but mybe Ruaduck can tell more ) Some Craft Genres have the Feature. Actually it would be enough, Changing the ID of Item + add for Gargoyles Only + Layer Change on a few Items. Whats maybe required is a List for each Genre what could be converted.
     
  19. Juzzver
    Offline

    Juzzver New Member

    Joined:
    Sep 17, 2013
    Messages:
    21
    Likes Received:
    0
    Yes, it is simple and suitable option.
     
  20. Crome969
    Offline

    Crome969 Member

    Joined:
    Jan 9, 2014
    Messages:
    195
    Likes Received:
    20
    http://uo2.stratics.com/miscellaneous/altering-items List of Types it use and there other part.

    I went Osi and looked , following Craftgenres have the altering :
    Tinker
    Blacksmith
    Tailor
    Carpentry

    Instead of making 4 Methods i would make a refering list into basecraftgump ( static) and convert if Tool is X and Type of Target is Y. You also can create Altering Scrolls by using a blank Scroll and create a RepairDeed Style Deed with following content :

    1094795 : An alter service contract (~1_SKILL_NAME~)
    Param0 : #1044067
    1050043 : crafted by ~1_NAME~
    Param0 : Testboy
    1060636 : exceptional
    1072788 : Weight: ~1_WEIGHT~ stone
    Param0 : 1

    Additional statrics says : Alter service contracts are created in the same way as repair deeds. The crafter selects ‘alter’ from the menu and targets a blank scroll. The contract can be used at a soulforge by any player.
    This is only half true, i tested this by using it with a Player owning the Skill for the Contract,if he had the skill he can use everywhere.
     
    #20 Crome969, Mar 14, 2014
    Last edited: Mar 18, 2014
Similar Threads: Update AlterItem
Forum Title Date
Archived Bug Reports Recent Update BladedItemTarget.cs Monday at 7:49 PM
ServUO Discussion Update Range and new Game Play Window Sizes Jul 24, 2017
ServUO Discussion Runic reforging updated needed on ServUO Jul 18, 2017
Archived Bug Reports Tomb of Kings issue since latest update Jul 14, 2017
Archived Bug Reports HouseRaffleStone needs update to take gold from "Account balance" Jul 9, 2017
Archived Bug Reports Since update Unwieldy not applying correctly to Jewlery Jul 9, 2017
Archived Bug Reports Termur Creature Update Jul 9, 2017