OP
Odd. I'm having no trouble crafting with boards or logs either one. And thats with using either the axe to create the boards or the Carp craft funtion. As for how they look, they should be looking like so..
Resource icon
- Thread starter Hammerhand
- Start date
Ahhhh interesting! I didn't even know you could make boards with an axe...so this narrows things down.
If I use an axe to make the boards they have the correct hue and name and i'm able to use them in crafting.
If i use the carpentry craft board function the boards have the correct hue but incorrect name and can't be used.
So could this be that board.cs is funky somehow?
YAY this works using boards made with an axe!
Booooo these don't work using the carpentry craft board option!
If I use an axe to make the boards they have the correct hue and name and i'm able to use them in crafting.
If i use the carpentry craft board function the boards have the correct hue but incorrect name and can't be used.
So could this be that board.cs is funky somehow?
YAY this works using boards made with an axe!
Booooo these don't work using the carpentry craft board option!
So something weird. I went to test the carpentry system finaly and every time I try to use the saw the server crashes, here is the log file.
[doublepost=1464754073][/doublepost]so after digging through code, seems something about the PM serialization got changed in the save methods and bombed out once I updated the defcarp. Made a new toon and it worked correctly when trying to open. (Good thing this is not yet a production shard).
Next issue. I spawn a log and turn it into boards, the log never goes away , however I get boards. Boards are also not accounted for in the carp gump.
Code:
Server Crash Report
===================
RunUO Version 0.5, Build 5984.39812
Operating System: Microsoft Windows NT 6.2.9200.0
.NET Framework: 4.0.30319.42000
Time: 5/31/2016 9:58:49 PM
Mobiles: 5251
Items: 123864
Exception:
System.ArgumentOutOfRangeException: Index was out of range. Must be non-negative and less than the size of the collection.
Parameter name: index
at System.Collections.CollectionBase.System.Collections.IList.get_Item(Int32 index)
at Server.Engines.Craft.CraftSubResCol.GetAt(Int32 index)
at Server.Engines.Craft.CraftGump..ctor(Mobile from, CraftSystem craftSystem, BaseTool tool, Object notice, CraftPage page)
at Server.Items.BaseTool.OnDoubleClick(Mobile from)
at Server.Mobile.Use(Item item) in k:\AlfheimRebornServer\Ultima Server\Server\Mobile.cs:line 4479
at Server.Engines.XmlSpawner2.XmlAttach.UseReq(NetState state, PacketReader pvSrc)
at Server.Network.MessagePump.HandleReceive(NetState ns) in k:\AlfheimRebornServer\Ultima Server\Server\Network\MessagePump.cs:line 187
at Server.Network.MessagePump.Slice() in k:\AlfheimRebornServer\Ultima Server\Server\Network\MessagePump.cs:line 115
at Server.Core.Main(String[] args) in k:\AlfheimRebornServer\Ultima Server\Server\Main.cs:line 579
Clients:
- Count: 1
+ 192.168.1.1: (account = romeov007) (mobile = 0x2B 'Ray')Next issue. I spawn a log and turn it into boards, the log never goes away , however I get boards. Boards are also not accounted for in the carp gump.
OP
OP
Not sure whats happening there @alchimyst I'm able to craft w/ regular wood just fine. Either from inside the MasterStorage or just in the backpack.
OP
Yeah, I know. Logs only show, but at least either logs or boards can be used for crafting.
OP
So
was already there, and did not show up so I added back the original code
and that got the wood option to show up. its ashame you cant easily change the string text for those entries, then I would simply add the rest of the boards manually to show up along side the logs
Code:
this.SetSubRes(typeof(Board), 1072643); // this line
Code:
this.AddSubRes(typeof(Board), 1072643, 00.0, 1044041, 1072652);and that got the wood option to show up. its ashame you cant easily change the string text for those entries, then I would simply add the rest of the boards manually to show up along side the logs
OP
Its the CraftGump.cs itself that isnt allowing the boards to show, even when the carp or fletch menu is set for them.
yeah I see that
For fun I tried adding
It actually showed up correctly with an amount however when trying to craft anything from it, the system thinks you have 0, despite the gump showing the amount
[doublepost=1464755763][/doublepost]bummer, think i somehow broke something, so i can only craft with regular logs/boards, any custom resources are showing with an amount but keeps stating I do not have enough.
For fun I tried adding
Code:
this.AddSubRes(typeof(OakBoard), "Oak Boards", 50.0, 1072652);It actually showed up correctly with an amount however when trying to craft anything from it, the system thinks you have 0, despite the gump showing the amount
[doublepost=1464755763][/doublepost]bummer, think i somehow broke something, so i can only craft with regular logs/boards, any custom resources are showing with an amount but keeps stating I do not have enough.
OP
You only need
None of the other CliLoc numbers are needed at the bottom for the subres. Just that line. But.. you just gave me an idea for an experiment. 
Code:
this.SetSubRes(typeof(Board), 1072643);Glad to be of help any idea though why any of my custom resources are not working for crafting? why it says I have insufficient wood yet It shows me having the wood.
[doublepost=1464758562][/doublepost]I attached my carp file for anyone wanting to skip the resourcehelper, which in my opinion is the root of the problem.. could be wrong bit this works for me! lol. this shows all logs and boards and the correct amounts and makes them usable. defaults to regular wood.
any idea though why any of my custom resources are not working for crafting? why it says I have insufficient wood yet It shows me having the wood.[doublepost=1464758562][/doublepost]I attached my carp file for anyone wanting to skip the resourcehelper, which in my opinion is the root of the problem.. could be wrong bit this works for me! lol. this shows all logs and boards and the correct amounts and makes them usable. defaults to regular wood.
OP
Now thats funny.. I was working on the same thing basically, just not quite as wordy. Dont really need the logs showing, especially since most arent going to keep them AS logs anyway. And these totals are from inside the MasterStorage, so it works all the way around.
.
Code:
this.AddSubRes(typeof(Board), 1072643, 00.0, 1044041, 1072652);
this.AddSubRes(typeof(OakBoard), 1072644, 65.0, 1044041, 1072652);
this.AddSubRes(typeof(AshBoard), 1072645, 80.0, 1044041, 1072652);
this.AddSubRes(typeof(YewBoard), 1072646, 95.0, 1044041, 1072652);
this.AddSubRes(typeof(HeartwoodBoard), 1072647, 100.0, 1044041, 1072652);
this.AddSubRes(typeof(BloodwoodBoard), 1072648, 100.0, 1044041, 1072652);
this.AddSubRes(typeof(FrostwoodBoard), 1072649, 100.0, 1044041, 1072652);
this.AddSubRes(typeof(EbonyBoard), "Ebony", 100.0, 1072652);
this.AddSubRes(typeof(BambooBoard), "Bamboo", 100.0, 1072652);
this.AddSubRes(typeof(PurpleHeartBoard), "PurpleHeart", 100.0, 1072652);
this.AddSubRes(typeof(RedwoodBoard), "Redwood", 100.0, 1072652);
this.AddSubRes(typeof(PetrifiedBoard), "Petrified", 100.0, 1072652);Meh I did ponder on the wordyness then i figured, if i did not be wordy, that ONE person (or more) would say 'WHAT IS THIS?!' so meh.
Im doing this to the rest of the craft gumps. lol
[doublepost=1464760159][/doublepost]I'm still not sure if I will keep the master storage accessible to players until I can get that loot gump fixed, i hate work arounds, to much explaining
[doublepost=1464761727][/doublepost]Here is my finished product, yes WORDY but its easy to change to less wordy.. lol tested them all, looks to be working as intended. even retaining resource colors which was not working with the resource helper
[doublepost=1464762101][/doublepost]By the way, i dislike the heartwood blue look, i actually enjoyed it green. by chance know where to change that hue? lol
Im doing this to the rest of the craft gumps. lol
[doublepost=1464760159][/doublepost]I'm still not sure if I will keep the master storage accessible to players until I can get that loot gump fixed, i hate work arounds, to much explaining
[doublepost=1464761727][/doublepost]Here is my finished product, yes WORDY but its easy to change to less wordy.. lol tested them all, looks to be working as intended. even retaining resource colors which was not working with the resource helper
[doublepost=1464762101][/doublepost]By the way, i dislike the heartwood blue look, i actually enjoyed it green. by chance know where to change that hue? lol
OP
Use the Add Single Item in the MasterStorage Options. Left click the MasterStorage pack, select Options. If its soemthing that isnt already there, what you target should get added. As for the Heartwood being blue.. lets see your ResourceInfo.cs It SHOULD be showing green..
Nope, it was set to blue.. LOL.
im fixing that asap
Code:
//daat99 OWLTR start - custom wood
new CraftResourceInfo( 0, 0, "Normal", CraftAttributeInfo.Blank, CraftResource.RegularWood, typeof(Board), typeof( Log ) ),
new CraftResourceInfo( 1281, 0, "Oak", CraftAttributeInfo.OakWood, CraftResource.OakWood, typeof(OakBoard), typeof( OakLog ) ),
new CraftResourceInfo( 488, 0, "Ash", CraftAttributeInfo.AshWood, CraftResource.AshWood, typeof(AshBoard), typeof( AshLog ) ),
new CraftResourceInfo( 2313, 0, "Yew", CraftAttributeInfo.YewWood, CraftResource.YewWood, typeof(YewBoard), typeof( YewLog ) ),
new CraftResourceInfo( 1262, 0, "Heartwood", CraftAttributeInfo.Heartwood, CraftResource.Heartwood, typeof(HeartwoodBoard), typeof( HeartwoodLog ) ),
new CraftResourceInfo( 1194, 0, "Bloodwood", CraftAttributeInfo.Bloodwood, CraftResource.Bloodwood, typeof(BloodwoodBoard), typeof( BloodwoodLog ) ),
new CraftResourceInfo( 1266, 0, "Frostwood", CraftAttributeInfo.Frostwood, CraftResource.Frostwood, typeof(FrostwoodBoard), typeof( FrostwoodLog ) ),
new CraftResourceInfo( 1457, 0, "Ebony", CraftAttributeInfo.Ebony, CraftResource.Ebony, typeof(EbonyBoard), typeof( EbonyLog ) ),
new CraftResourceInfo( 1719, 0, "Bamboo", CraftAttributeInfo.Bamboo, CraftResource.Bamboo, typeof(BambooBoard), typeof( BambooLog ) ),
new CraftResourceInfo( 114, 0, "PurpleHeart", CraftAttributeInfo.PurpleHeart, CraftResource.PurpleHeart, typeof(PurpleHeartBoard), typeof( PurpleHeartLog ) ),
new CraftResourceInfo( 37, 0, "Redwood", CraftAttributeInfo.Redwood, CraftResource.Redwood, typeof(RedwoodBoard), typeof( RedwoodLog ) ),
new CraftResourceInfo( 1153, 0, "Petrified", CraftAttributeInfo.Petrified, CraftResource.Petrified, typeof(PetrifiedBoard), typeof( PetrifiedLog ) ),
//daat99 OWLTR end - custom woodim fixing that asap
OP
This is from mine..
Code:
new CraftResourceInfo( 0x000, 1011542, "Normal", CraftAttributeInfo.Blank, CraftResource.RegularWood, typeof(Board), typeof( Log ) ),
new CraftResourceInfo( 0x7DA, 1072533, "Oak", CraftAttributeInfo.OakWood, CraftResource.OakWood, typeof(OakBoard), typeof( OakLog ) ),
new CraftResourceInfo( 0x4A7, 1072534, "Ash", CraftAttributeInfo.AshWood, CraftResource.AshWood, typeof(AshBoard), typeof( AshLog ) ),
new CraftResourceInfo( 0x4A8, 1072535, "Yew", CraftAttributeInfo.YewWood, CraftResource.YewWood, typeof(YewBoard), typeof( YewLog ) ),
new CraftResourceInfo( 0x4A9, 1072536, "Heartwood", CraftAttributeInfo.Heartwood, CraftResource.Heartwood, typeof(HeartwoodBoard), typeof( HeartwoodLog ) ),
new CraftResourceInfo( 0x4AA, 1072538, "Bloodwood", CraftAttributeInfo.Bloodwood, CraftResource.Bloodwood, typeof(BloodwoodBoard), typeof( BloodwoodLog ) ),
new CraftResourceInfo( 0x47F, 1072539, "Frostwood", CraftAttributeInfo.Frostwood, CraftResource.Frostwood, typeof(FrostwoodBoard), typeof( FrostwoodLog ) ),
new CraftResourceInfo( 1457, 0, "Ebony", CraftAttributeInfo.Ebony, CraftResource.Ebony, typeof(EbonyBoard), typeof( EbonyLog ) ),
new CraftResourceInfo( 1719, 0, "Bamboo", CraftAttributeInfo.Bamboo, CraftResource.Bamboo, typeof(BambooBoard), typeof( BambooLog ) ),
new CraftResourceInfo( 114, 0, "PurpleHeart", CraftAttributeInfo.PurpleHeart, CraftResource.PurpleHeart, typeof(PurpleHeartBoard), typeof( PurpleHeartLog ) ),
new CraftResourceInfo( 37, 0, "Redwood", CraftAttributeInfo.Redwood, CraftResource.Redwood, typeof(RedwoodBoard), typeof( RedwoodLog ) ),
new CraftResourceInfo( 1153, 0, "Petrified", CraftAttributeInfo.Petrified, CraftResource.Petrified, typeof(PetrifiedBoard), typeof( PetrifiedLog ) ),
OP
Which bugs?
[doublepost=1464763319][/doublepost]I think I know what happened with that hue. Higher client than the one it was originally done on. And now I have the original hue CliLocs in it, so the hues will be accurate.
[doublepost=1464763319][/doublepost]I think I know what happened with that hue. Higher client than the one it was originally done on. And now I have the original hue CliLocs in it, so the hues will be accurate.
The only one I did not mention yet was all the elemental scripts have invalid options in them per the current distro, such as packmagicitems, which will cause a fail to compile. I ended up re doing them all to match closer to AirElementals but with their respective resources. also, i removed the autodispel which was counter intuitive in my scenario. Now that I got past the crafting system, now im going to really dig into the rest of the system and make sure everything is working like it should be
OP
I just remove the PackMagicitems. Oddly enough, it wasnt an issue until some update to ServUO between the time I released it & recently.
OP
Not surprised. Ore ele's really dont need them anyway. Just the ability to drop their respective ores & runics. And have the hue OF that ore of course. And be harder to kill than others. And the ability to spawn on top of you when you use a Gargoyle Pickaxe for mining. And the ability to let you know they spawned by a sudden black screen saying you died. Thats all thats really needed for them. lol
HH I figured it out!! The section about boards in CraftItem.cs was missing the entries for the custom woods. Now I can craft using logs and boards of any type and they're hued and named correctly. The code in CraftItem.cs should look like this around line 1500ish:
[doublepost=1464806875][/doublepost]Ok so now that all the fun and games with boards and logs is done (YAY!) I'm running into a cosmetic issue with material type being listed on items.
Here I've made two thrones, one out of frostwood (a normal OSI wood) and one out of purpleheart wood (a custom wood).
The frostwood one says Frostwood, the Purpleheart one does not. Any idea where this may be hiding out at?
Code:
#region Mondain's Legacy
if (item is Board)
{
Type resourceType = typeRes;
if (resourceType == null)
{
resourceType = Resources.GetAt(0).ItemType;
}
CraftResource thisResource = CraftResources.GetFromType(resourceType);
switch (thisResource)
{
case CraftResource.OakWood:
item = new OakBoard();
break;
case CraftResource.AshWood:
item = new AshBoard();
break;
case CraftResource.YewWood:
item = new YewBoard();
break;
case CraftResource.Heartwood:
item = new HeartwoodBoard();
break;
case CraftResource.Bloodwood:
item = new BloodwoodBoard();
break;
case CraftResource.Frostwood:
item = new FrostwoodBoard();
break;
case CraftResource.Ebony:
item = new EbonyBoard();
break;
case CraftResource.Bamboo:
item = new BambooBoard();
break;
case CraftResource.PurpleHeart:
item = new PurpleHeartBoard();
break;
case CraftResource.Redwood:
item = new RedwoodBoard();
break;
case CraftResource.Petrified:
item = new PetrifiedBoard();
break;
default:
item = new Board();
break;
}
}
#endregionHere I've made two thrones, one out of frostwood (a normal OSI wood) and one out of purpleheart wood (a custom wood).
The frostwood one says Frostwood, the Purpleheart one does not. Any idea where this may be hiding out at?
OP
@alchimyst Mine has been crafting with hues for wood from the beginning without adding that to CraftItem.cs It isnt showing the resource name because there are no CliLocs for them.
[doublepost=1464821635][/doublepost]@Joshua That would be in daat99's TokenSystem.cs, in the GiveTokens section.
[doublepost=1464821635][/doublepost]@Joshua That would be in daat99's TokenSystem.cs, in the GiveTokens section.
OP
Yeah, unfortunately. All I added into DefCarpentry & DefBowFletching was this.
Which allows it to show the wood hue on crafted items. Between that & an addition to LockableContainer.cs, most wood items show the wood hue.
Code:
private DefCarpentry()
: base(1, 1, 1.25)// base( 1, 1, 3.0 )
{
}
public override bool RetainsColorFrom(CraftItem item, Type type) // These 4 lines
{
return true;
}
public override int CanCraft(Mobile from, BaseTool tool, Type itemType)Okeydokey HH than all is working as it should for that portion of things! Super appreciate the help and time you've put into this awesome system. So now that the resources are finished i'm testing everything before i pack it all up.
Looks like I'm now running into an issue Ether had with Carpentry BODS.
Seems I can't add musical instruments to BODs for some reason. Just says "not requested item".
If i props the BOD and change the AmountCur to what it needs to be i'm able to turn it in fine and get a reward. Other carpentry bods are fine.
-Alch
Looks like I'm now running into an issue Ether had with Carpentry BODS.
Seems I can't add musical instruments to BODs for some reason. Just says "not requested item".
If i props the BOD and change the AmountCur to what it needs to be i'm able to turn it in fine and get a reward. Other carpentry bods are fine.
-Alch
Last edited:
@ alchemist - I tested your issue and I was also able to replicate it
[doublepost=1464907704][/doublepost]Fixed half the problem.. in SmallBod.CS
Find this section
Add type ' Item '
So it looks like this
The only problem I have now is it keeps stating it's not made from the right material, I do not think drums can be made from ashwood in my case. I tried selecting the resource ashwood and making the drums however I do not think it's actually tagging them with the wood type.
[doublepost=1464907834][/doublepost]So either we would need to fix the bod so it only made item types from normal wood not custom wood, or fix the item type so it can have a custom resource.
[doublepost=1464907704][/doublepost]Fixed half the problem.. in SmallBod.CS
Find this section
Code:
public void EndCombine(Mobile from, object o)
{
if (o is Item && ((Item)o).IsChildOf(from.Backpack))
{
Type objectType = o.GetType();
if (this.m_AmountCur >= this.m_AmountMax)
{
from.SendLocalizedMessage(1045166); // The maximum amount of requested items have already been combined to this deed.
}
else if (this.m_Type == null || (objectType != this.m_Type && !objectType.IsSubclassOf(this.m_Type)) || (!(o is BaseWeapon) && !(o is BaseArmor) && !(o is BaseClothing)))
{
from.SendLocalizedMessage(1045169); // The item is not in the request.
}
else
{Add type ' Item '
So it looks like this
Code:
public void EndCombine(Mobile from, object o)
{
if (o is Item && ((Item)o).IsChildOf(from.Backpack))
{
Type objectType = o.GetType();
if (this.m_AmountCur >= this.m_AmountMax)
{
from.SendLocalizedMessage(1045166); // The maximum amount of requested items have already been combined to this deed.
}
else if (this.m_Type == null || (objectType != this.m_Type && !objectType.IsSubclassOf(this.m_Type)) || (!(o is BaseWeapon) && !(o is BaseArmor) && !(o is Item) && !(o is BaseClothing)))
{
from.SendLocalizedMessage(1045169); // The item is not in the request.
}
else
{The only problem I have now is it keeps stating it's not made from the right material, I do not think drums can be made from ashwood in my case. I tried selecting the resource ashwood and making the drums however I do not think it's actually tagging them with the wood type.
[doublepost=1464907834][/doublepost]So either we would need to fix the bod so it only made item types from normal wood not custom wood, or fix the item type so it can have a custom resource.
Last edited:
OP
*sigh* Ok, you want those BODs to work as well? Sheesh.... greedy, arent ya'? Fine... consider them FIXED. Joshua was on the right track, just didnt go far enough. Edits to both SmallBOD.cs AND BaseInstrument.cs were needed. Instruments had nothing at all for resources, so I had to add that in & add in checks for BaseInstrument into SmallBOD.cs Drop these in to overwrite or merge them & you should be able to add crafted instruments to the Carp BODs. I just added BODs for each type of instrument on my tester, crafted one of each type & was able to add them to the BODs. Happy now?
Joshua was on the right track, just didnt go far enough. Edits to both SmallBOD.cs AND BaseInstrument.cs were needed. Instruments had nothing at all for resources, so I had to add that in & add in checks for BaseInstrument into SmallBOD.cs Drop these in to overwrite or merge them & you should be able to add crafted instruments to the Carp BODs. I just added BODs for each type of instrument on my tester, crafted one of each type & was able to add them to the BODs. Happy now?
OP
I dont even buy myself ice cream most of the time & as for a pony.. script one yourself. I dont drink & the FedEx guy would probably eat the pizza and/or drink the beer. Just use the scripts, craft instruments & get gold for the BODs.